What changes to Inline module are exactly needed to have thickbox support in Inline module?

Please move this issue to the Inline issue queue after clarification.

Comments

frjo’s picture

frjo commented

I have built in support in my own version of the inline module.

http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/frjo/inline5/

I just add attribute class "thickbox" and rel "gallery-[nid]" to image links. The gallery part makes thickbox treat all images in the same node as a gallery.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Instead of maintaining a copy of Inline module, you should use an approach like jLightbox:

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/jlightbox/j...

That javascript is written to integrate Image Assist module with jLightbox. It is automatically loaded, if Image module is enabled. However, the only thing that basically would need to be altered is the element class selector. Inline uses the class inline. If you need a more specific class name, just let me know and I'll add something like inline-image to Inline module.

frjo’s picture

frjo commented
Assigned: Unassigned » frjo

Thickbox already does this for image nodes with thickbox_auto.js so it should not be difficult to do with inline also.

I see that the latest inline module adds a class "inline-image-link" to the link tag around the image, that makes it easy to find all inline images.

I will do some testing and report back here.

My own inline module does a lot of stuff that I need, Thickbox support is only one of them.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Great. Regarding the other features, I would be happy to review and work on patches for Inline module if you'd supply feature requests. Maintaining a fork of Inline just to have a few more features is certainly not a good approach and will confuse users who want to use both Inline and Thickbox modules.

frjo’s picture

frjo commented
Status: Active » Closed (fixed)

Closing old issues, please reopen and update if there is a need for it.