Views provides Edit and Delete links for core entity types like nodes.

File entity module should provide analogous handlers for file entities because it is providing the file/%file/edit and file/%file/delete paths.

This should be a relatively straightforward patch.

CommentFileSizeAuthor
#15 edit_delete_links_file_entity_1778370_14.patch5.46 KBslashrsm
#14 edit_delete_links_file_entity_1778370_14.patch0 bytesslashrsm
#14 interdiff_12_14.txt1.7 KBslashrsm
#12 edit_delete_links_file_entity_1778370_12.patch5.43 KBslashrsm
#9 views_field_handler_links-1778370-9.patch1.97 KBcircuscowboy
#7 views_field_handler_links-1778370-7.patch5.45 KBcircuscowboy
#4 views_field_handler_links-1778370-4.patch5.43 KBJackinloadup
#4 innerdiff.txt2.72 KBJackinloadup
#1 views_field_handler_links-1778370-1.patch5.43 KBstevector

Comments

stevector’s picture

stevector
he/him
commented
Status: Active » Needs review
StatusFileSize
new views_field_handler_links-1778370-1.patch5.43 KB

I also added a View link that goes to file/%fid

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

Please make the links use Sentence case ('Edit' not 'edit'). Looks like two of the titles in file_entity_views_data() also need to be fixed: t('link') and t('delete').

alex.skrypnyk’s picture

alex.skrypnyk
he/him
Primary language English
Location Melbourne
commented

Thanks for the patch - works great!
Could you please make the requested adjustments so it can be merged with HEAD.

Jackinloadup’s picture

Jackinloadup commented
StatusFileSize
new innerdiff.txt2.72 KB
new views_field_handler_links-1778370-4.patch5.43 KB

Here are the requested changes.

This patch will be affected by #1227706: Add a file entity access API

devin carlson’s picture

devin carlson commented
Status: Needs work » Needs review
ParisLiakos’s picture

ParisLiakos commented

#4: views_field_handler_links-1778370-4.patch queued for re-testing.

circuscowboy’s picture

circuscowboy commented
StatusFileSize
new views_field_handler_links-1778370-7.patch5.45 KB

updated patch to play nice with #1227706: Add a file entity access API

Status: Needs review » Needs work

The last submitted patch, views_field_handler_links-1778370-7.patch, failed testing.

circuscowboy’s picture

circuscowboy commented
StatusFileSize
new views_field_handler_links-1778370-9.patch1.97 KB

Lets try again

circuscowboy’s picture

circuscowboy commented
Status: Needs work » Needs review
Anonymous’s picture

Anonymous (not verified) commented

Thanks for the patch. I noticed that latest patch doesn't include the 3 new views includes. I had to pull those from the previous patch.

slashrsm’s picture

slashrsm commented
StatusFileSize
new edit_delete_links_file_entity_1778370_12.patch5.43 KB

Here is re-rolled patch with classes included.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Needs work 
+++ b/views/views_handler_field_file_link.incundefined
@@ -0,0 +1,48 @@
+    if (file_entity_access('view')) {

Please pass $file as argument

+++ b/views/views_handler_field_file_link_delete.incundefined
@@ -0,0 +1,31 @@
+    if (!file_entity_access('edit')) {

Same and use update instead of edit

+++ b/views/views_handler_field_file_link_edit.incundefined
@@ -0,0 +1,31 @@
+    // Ensure user has access to edit this file.

same and use delete isntead of edit

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_12_14.txt1.7 KB
new edit_delete_links_file_entity_1778370_14.patch0 bytes

Here it is...

slashrsm’s picture

slashrsm commented
StatusFileSize
new edit_delete_links_file_entity_1778370_14.patch5.46 KB

Corrected patch for #14.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

i think its good to go

ParisLiakos’s picture

ParisLiakos commented
Status: Reviewed & tested by the community » Fixed

thanks to all of you and sorry for the delay
commited

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.