Revisions not updating status properly

I've spent some more time tracing back this issue with mixed success. There seem to be two points in the workflow where there are problems, which occur when you use the "Publish the most recent pending revision action" through Rules:

• Regarding the setting of node->status when a newly created node is shifted to publish through Rules, I could not find why it was not being changed to 1, but have easily worked around it by adding an extra action to the rule I'd already created to compensate.
• When you try to publish the latest revision to an existing node through rules there are two places where it fails:
• Firstly, the SQL query "SELECT r.vid, r.title, n.type FROM {node} n INNER JOIN {node_revision} r ON n.nid = r.nid WHERE (r.vid = n.vid AND n.nid = :nid) ORDER BY r.vid DESC" called at function _revisioning_get_pending_revisions (line 578) does not return any rows. This is particularly odd as the same query run in phpmyadmin returns the expected row referring to the revision.
  I have found that changing the query to "SELECT r.vid, r.title, n.type FROM {node} n INNER JOIN {node_revision} r ON n.nid = r.nid WHERE (r.vid >= n.vid AND n.nid = :nid) ORDER BY r.vid DESC" fixes the problem and returns that one row which is wanted, even though the same query in phpmyadmin also returns the row representing the current revision. I cannot fathom the logic of this, but it seems to work.
• Secondly, even if you work around the first problem I have found that when it gets to the function revisioning_node_update, although the db_update('node') command at line 598 assigns all the correct values to the update task, it is not actually updating them to the node table in the database (but I cannot see any evidence of where or why it is failing). I have not managed to come up with a stop-gap work-around for this (let alone a proper solution) so any assistance would be greatly appreciated.

Hopefully for someone more knowledge than me can figure out what is going on, because I could do with getting this working on the site I am building quite urgently.

Thanks.

Paul

Unfortunately I really could do with the extra options that Workflow allows.

I have some more information on the third issue regarding the database update. I analysed it slightly wrong:

• function _revisioning_publish_revision is updating the node table correctly (revisioning_api.inc line 455).
• However,by the time revisioning_node_update runs its db_update (revisioning.module line 598) it has picked up the old values, but I haven't yet detected from where these have come from.

Paul

No. I did try it as it looked good, but when I used the buttons it generated the error "Fatal error: Call to undefined function workflow_tab_form_submit()" and since it came in the category of 'nice to have' rather than essential I uninstalled it.

Having watched the variable $node->current_revision_id (which is one of the variables that is reverting to its previous value) the point at which it changes is in the function _revisioning_publish_latest_revision of revisioning_api.inc. It has the correct version of this variable just before it finishes running _revisioning_publish_revision at line 517, but has switched to the previous version by the time it reaches line 518. For clarity I have copied the relevant section of code with line numbers.

511 function _revisioning_publish_latest_revision(&$node) {
512   // Get the latest pending revision
513   $pending_revisions = _revisioning_get_pending_revisions($node->nid);
514   $latest_pending = array_shift($pending_revisions);
515   if ($latest_pending) {
516     $node_revision = node_load($node->nid, $latest_pending->vid);
517     _revisioning_publish_revision($node_revision);
518    return TRUE;
519 }

Paul

I'm still no closer to working out this problem. Is there anyone else out there using Revisioning with Workflow in Drupal 7 and triggering publication using a Rule? If you are not having the problems I'm having getting a node to actually publish please can you let me know what Rule conditions and actions are you using?

Thank you.

Paul

In order to double check it is not a conflict with another module I have set up this process on a completely clean minimal install of the latest version of Drupal adding only Revisioning and Workflow and those modules they depend upon, closely following the tutorial for Revisioning with state-based access control. Unfortunately I am still getting exactly the same problem with nodes not actually publishing.

Is anyone more knowledgeable than me able to take a look at this problem and see if they can detect what is going wrong?

For reference the modules I had installed in this latest test were:

• From Core 7.17
• Block
• Database logging
• Field
• Field SQL storage
• Filter
• Node
• System
• Text
• Update Manager
• User
• From Entity API 7.x-1.0-rc3:
• Entity API
• Entity Tokens
• From Revisioning 7.x-1.4+4-dev
• Revisioning
• From Rules 7.x.2.2
• Rules
• Rules UI
• From Workflow 7.x.1.0
• Workflow
• Workflow access
• Workflow rules
• Workflow UI

Thank you

Paul

The rule is (as stated in my first description of the problem):
Event "Workflow state has changed",
Condition: Content has a workflow state; Parameter: Node: [node], Compare workflow state: Live
Action: Publish the most recent pending revision; Parameter: content: [node]

This rule is validating the condition as met when the node's workflow state is updated to Live and is firing the action as it should (I had less success with other variants on the conditions). Following the code as it is run, the action within the Revisioning module is being run through and not failing, but it does not actually produce the expected state change to mark the revision as published.

Your assistance would be greatly appreciated.

Paul

Rik

Is there any possibility that you might be able to look at this problem with the publish revision rule in the nearish future? I think I have exhausted my ability to find a solution for the problem and if no one else can help I am going to have to start exploring alternate solutions to meet my site's needs (which I don't want to have to do as this module would be ideal if it worked).

Paul

Rik

Happy New Year. Did you have any luck isolating the problem?

Paul

Thank you for what you have done so far. I hope you can return to it soon.
Paul

Rik

Any chance you are going to be able to look at this again in the nearish future?

Paul

Short answer: I think I might have solved my problem by changing the trigger event for my rule.

Long answer:
I attempted to replicate the bug in a clean install without Workflow (as per Rik's request), but was unable to do so. All the rules I created successfully published the latest revision.

So I tried adding in the flag module (since scoellis reported it was having the same problem as I was having with Workflow) but was still able to get it to work. However I did have a couple of issues along the way. If the flag was changed on the node view page it didn't update until after the page was refreshed and if the flag was set on the node edit page the "A node has been flagged event" didn't fire but checking the flag status as a condition of an "After updating existing content" event did work).

This led me to try using the "After updating existing content" event for my rule instead of the "Workflow state has changed" event trigger (even though the rule was firing successfully). This revised rule not only fired, but its publishing action was saved correctly. For reference the condition was still "Content has a workflow state; Parameter: Node: [node], Compare workflow state: Live" and the action was "Publish the most recent pending revision; Parameter: content: [node]". My best guess is that Workflow event fires at a point in the save process that allows the actions related to it to be overwritten by later events in the save sequence.

It is possible that this latest success was caused by changes to one or more modules since I last tested, but whatever it is I hope this information allows other people to get their publishing rules working too. Thank you all for your help in leading me to this solution.

Paul

Rik

The installation was:
Drupal Core 7.22 minimal installation
Revisioning 7.x-1.x-dev - 4 April 2013
Rules and Rules UI 7.x-2.3
Entity API and Entity Tokens 7.x-1.0

I then added:
Flag 7.x-2.0
Workflow 7.x-1.1

I have since tested that my workflow rule works on my full development site with these and many more modules installed.

Paul