[D7] Node Revision Delete [#1780980]

The Node Revision Delete module allows you to manage the revisions of the Node according to your choice. It helps you to keep the specific number of revisions for the node. This module provides you the flexibility for applying the revision delete for the specific content type and run it on the specific time.

The reason for creating this type of project that I searched the drupal modules for deleting the node revisions, but I didnt get. So I wrote a very simple and small application module to do this operation.

Project Page : http://drupal.org/sandbox/kaushalrahuljaiswal/1779880
GIT url : http://git.drupal.org/sandbox/kaushalrahuljaiswal/1779880
Drupal version : 7.x
Pareview : http://ventral.org/pareview/httpgitdrupalorgsandboxkaushalrahuljaiswal17...

Comment	File	Size	Author
	node_revision_delete.zip	41.37 KB	kaushalkishorejaiswal

Comments

Comment #1

hkirsman commented 11 September 2012 at 09:35

You should add Project page, GIT url, Drupal version and pareview like this: http://drupal.org/node/1773848

Also .zip includes 2 .git repositories and folder name is 1779880 not node_revision_delete . I would delete it alltogether. Url to git is enough.

Also, you should rename branch master to 7.x-1.x. I had the same problem (pushed to master) but I could not update repo on drupal.org so I deleted the project, renamed repository locally and pushed it back to the new project. See here - http://drupal.org/project/1763900/git-instructions. No master branch. In Drupal world everything is in version branch and master is always empty.

Comment #2

kaushalkishorejaiswal commented 12 September 2012 at 11:47

As you metioned the issues in the Comment, I have resolved it all. Please check it and review it!!!!!!!!!!!!!

Comment #3

jrsinclair commented 12 September 2012 at 23:32

Status:

Needs review

» Reviewed & tested by the community

Hi @kaushalrahuljaiswal,

You should replace the git link in the issue summary with just http://git.drupal.org/sandbox/kaushalrahuljaiswal/1779880, this will make it easier for potential reviewers to download your code. The link you have there now is only accessible to yourself. Also perhaps just delete the attachment as it will confuse people.

Good work on passing all the automated review checks. This makes the reviewer's job much easier.

This is an extremely minor issue, but could you remove the executable flag of all the files in the repository? It occasionally causes problems for people who use Git on Windows, and doesn't really provide any benefit for anyone else.

Another very minor point is that the naming of the variable $total_revision_delete is a little bit confusing, since it appears to store the number of revisions you ant to keep, rather than the number of revisions you want to delete.

All of these issues are really minor. Marking RTBC. Good work.

Comment #3.0

jrsinclair commented 12 September 2012 at 23:32

Issue summary:

View changes

Updation for review Comment 1

Comment #4

kaushalkishorejaiswal commented 13 September 2012 at 05:31

Hi jrsinclair,
First of all thanks for your review for my module, I have completed all the changes that you have mentioned. But little confusion on

Paragraph 3: This is an extremely minor issue, but could you remove the executable flag of all the files in the repository? It occasionally causes problems for people who use Git on Windows, and doesn't really provide any benefit for anyone else.

I have changed the permission, but not sure how to check it, and I dont know how to delete the attachment. Can you pls tell me that how can I delete the attachment.
Thx in advance!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Thanks,
Kaushal Kishore

Comment #5

chx commented 13 September 2012 at 05:56

Status:

Reviewed & tested by the community

» Fixed

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.