Patch forthcoming. Getting issue number for filenaming.

CommentFileSizeAuthor
#4 forward-log-views-1782322-4.patch5.25 KBgrasmash
#3 forward-log-views-1782322-3.patch5.24 KBgrasmash
#1 forward-log-views-1782322-1.patch5.11 KBgrasmash

Comments

grasmash’s picture

grasmash commented
StatusFileSize
new forward-log-views-1782322-1.patch5.11 KB

A couple of thoughts about this:

  • We may want to add a default view for this table in forward.views_default.inc
  • It would be great if we could create a relationship to a given shared node. Unfortunately, this may require changing the way that the forward module stores data in {forward_log}. E.g., we could have a 'path_type' column that would store 'node', 'user', 'arbitrary.' We would then also have a 'content_id' column, allowing us to easily find which shared paths were to nodes, and pull in information like the title of that node.
grasmash’s picture

grasmash commented
Status: Active » Needs review

Changing status.

grasmash’s picture

grasmash commented
StatusFileSize
new forward-log-views-1782322-3.patch5.24 KB

Adding 'click sortable' to field handlers.

grasmash’s picture

grasmash commented
StatusFileSize
new forward-log-views-1782322-4.patch5.25 KB

Adding working filters for all columns.

john.oltman’s picture

john.oltman commented

Great, I will try this out when I get a chance, and assuming all is well, will commit to 7.x branch thereafter. Thanks for submitting this feature.

john.oltman’s picture

john.oltman commented
Status: Needs review » Fixed

This is fantastic! Worked like a champ. Committed and will be in next DEV build.

grasmash’s picture

grasmash commented

Great. Any thoughts on these points?

  • We may want to add a default view for this table in forward.views_default.inc
  • It would be great if we could create a relationship to a given shared node. Unfortunately, this may require changing the way that the forward module stores data in {forward_log}. E.g., we could have a 'path_type' column that would store 'node', 'user', 'arbitrary.' We would then also have a 'content_id' column, allowing us to easily find which shared paths were to nodes, and pull in information like the title of that node.
john.oltman’s picture

john.oltman commented

Those are both solid ideas, especially the ability to relate the log to nodes. I don't have the bandwidth to make those changes at this point. Would you want to take a shot? If not, we can defer to a future release. I'd like to get a new official release out on October 1.

grasmash’s picture

grasmash commented

I may have the time to do those changes before October 1. The default view would be a quick thing, I'll look more closely at changing the schema.

Would you give me commit access to the repository? If not, I'll generate a patch.

john.oltman’s picture

john.oltman commented

It would have to be a patch as I don't have the access level required to add maintainers. If you expect to do a lot more with the module, you could request maintainer status, and someone else within d.o would review that request and act on it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.