Posted by ezra-g on September 12, 2012 at 9:14pm
5 followers
| Project: | Drupal Commons |
| Version: | 7.x-3.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | erikwebb |
| Status: | closed (fixed) |
Issue Summary
- 2.x branch of http://drupal.org/project/aloha
- Full HTML and Filtered HTML input formats Featurized to replace what's currently in Commons.install.
Comments
#1
Just adding a reference to the install info http://drupalcode.org/project/aloha.git/blob/refs/heads/7.x-2.x:/README.txt
So as far as 7.x core goes, would currently also require adding a patch to core to establish different filter types (edit: oops, no that's not what this patch does, it does something to drupal_get_js), removing the transformational filters in full/filtered input formats (urls to links / line break conversion), and the 2.x version of jquery_update dev with jquery 1.7 enabled.
#2
#3
Note: As per https://drupal.org/node/1664602#comment-6339042, this approach does not currently work with JS aggregation enabled.
#4
Also gives a warning for filters like media token filter that don't tell Aloha what kind of filter they are (transformational etc.). We'll probably keep on getting warned about that until a patch makes it into core which triggers a patch to modules with filters like media.
There's an issue out for core 8.x #807996: [meta] Input filters and text formats
For a start this is only a problem for inline editing which I don't think there's any plans for Commons to use, and if it did I suppose until we have patches we can apply, Aloha will just overwrite tokens with their rendered html. While that's a bit pants it's not exactly the end of the world, so it would seem to make sense to remove this warning from Aloha module in the interim.
#5
Because of the blocking issue, I won't be able to resolve this in a timeframe for my project.
#6
Solved; see #1787940: Allow for JS aggregation yet prevent the data-aloha-defer-init attribute on aloha.js' script tag from being removed and #1664602-14: drupal_add_js() defer and async options break when aggregation is enabled (Replace with universal attributes array).
#7
https://drupal.org/project/commons_wysiwyg
#8
Basic patch to -
#9
#10
I removed the input format-related code from commons.install and tested this on a fresh install - Seems to be working great. This is committed. Thanks, erikwebb!
http://drupalcode.org/project/commons.git/commit/e54d046
#11
Automatically closed -- issue fixed for 2 weeks with no activity.