Closed (fixed)
Project:
Drupal Commons
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
12 Sep 2012 at 21:14 UTC
Updated:
3 Oct 2012 at 20:31 UTC
Jump to comment: Most recent file
- 2.x branch of http://drupal.org/project/aloha
- Full HTML and Filtered HTML input formats Featurized to replace what's currently in Commons.install.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | commons-basic_wysiwyg_config-1782892-8.patch | 2.08 KB | erikwebb |
Comments
Comment #1
lightsurge commentedJust adding a reference to the install info http://drupalcode.org/project/aloha.git/blob/refs/heads/7.x-2.x:/README.txt
So as far as 7.x core goes, would currently also require adding a patch to core to establish different filter types (edit: oops, no that's not what this patch does, it does something to drupal_get_js), removing the transformational filters in full/filtered input formats (urls to links / line break conversion), and the 2.x version of jquery_update dev with jquery 1.7 enabled.
Comment #2
erikwebb commentedComment #3
erikwebb commentedNote: As per https://drupal.org/node/1664602#comment-6339042, this approach does not currently work with JS aggregation enabled.
Comment #4
lightsurge commentedAlso gives a warning for filters like media token filter that don't tell Aloha what kind of filter they are (transformational etc.). We'll probably keep on getting warned about that until a patch makes it into core which triggers a patch to modules with filters like media.
There's an issue out for core 8.x #807996: [meta] Input filters and text formats
For a start this is only a problem for inline editing which I don't think there's any plans for Commons to use, and if it did I suppose until we have patches we can apply, Aloha will just overwrite tokens with their rendered html. While that's a bit pants it's not exactly the end of the world, so it would seem to make sense to remove this warning from Aloha module in the interim.
Comment #5
erikwebb commentedBecause of the blocking issue, I won't be able to resolve this in a timeframe for my project.
Comment #6
wim leersSolved; see #1787940: Allow for JS aggregation yet prevent the data-aloha-defer-init attribute on aloha.js' script tag from being removed and #1664602-14: Allow attributes to be passed to drupal_add_[css|js] (SRI).
Comment #7
erikwebb commentedhttps://drupal.org/project/commons_wysiwyg
Comment #8
erikwebb commentedBasic patch to -
Comment #9
erikwebb commentedComment #10
ezra-g commentedI removed the input format-related code from commons.install and tested this on a fresh install - Seems to be working great. This is committed. Thanks, erikwebb!
http://drupalcode.org/project/commons.git/commit/e54d046