It looks like Aegir backend needs some review to make sure we really follow Drupal API changes where required, or we may end up with some mysteriously not really working tasks or their internal logic.

Comments

omega8cc’s picture

omega8cc commented
Status: Active » Needs review

First patch for review: http://drupalcode.org/sandbox/omega8cc/1111100.git/commit/bb6db87

omega8cc’s picture

omega8cc commented

Second patch for review: http://drupalcode.org/sandbox/omega8cc/1111100.git/commit/3ba982a

steven jones’s picture

steven jones commented
Status: Needs review » Needs work

Re: #1 I'm fairly certain that we don't include that file any more, and instead in drush_provision_drupal_pre_provision_verify we run:

drush_set_option('packages', _scrub_object(provision_drupal_system_map()), 'site');

Re: #2 looks good, although this will need lots of careful testing, as flushing Drupal's caches can often cause issues.

omega8cc’s picture

omega8cc commented
Status: Needs work » Closed (duplicate)

I have managed to create a duplicate: #1696232: Use drupal_flush_all_caches() in clear_(6,7,8).inc instead of outdated and no longer complete d5 functions - sorry!

anarcat’s picture

anarcat commented

The second patch is a dupe, but the first one - is it still necessary?

omega8cc’s picture

omega8cc commented

Steven said in #3 that it is not used anyway - and I think it is correct, because otherwise this old code would cause major issues for D7 sites because of Drupal API changes.

  • Commit 95ee9d1 on dev-drupal-8, 6.x-2.x, dev-ssl-ip-allocation-refactor, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by omega8cc, committed by anarcat: 
    Issue #1785624 by omega8cc - Some Drupal API changes in D7 (and D8) are...
  • Commit fd0e24d on 7.x-3.x, dev-helmo-3.x authored by omega8cc, committed by helmo:
    Issue #1785624 by omega8cc - Some Drupal API changes in D7 (and D8) are...

  • anarcat committed 95ee9d1 on authored by omega8cc 
    Issue #1785624 by omega8cc - Some Drupal API changes in D7 (and D8) are...
  • helmo committed fd0e24d on authored by omega8cc
    Issue #1785624 by omega8cc - Some Drupal API changes in D7 (and D8) are...

  • anarcat committed 95ee9d1 on 7.x-3.x-1966886-context-to-entity authored by omega8cc 
    Issue #1785624 by omega8cc - Some Drupal API changes in D7 (and D8) are...

  • anarcat committed 95ee9d1 on 6.x-2.x-1995506-profile-option authored by omega8cc 
    Issue #1785624 by omega8cc - Some Drupal API changes in D7 (and D8) are...