Quickfields

I really like your module!

The module works as expected for me,
but you should solve the problems from the automated project review:
http://ventral.org/pareview/httpgitdrupalorgsandboxsandervd1787738git

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Hi Sander,

Before anything else: Happy new year!
This module is interesting and I personally find it more useful for existing fields than initial default values :-)

Coder, Coder tough love: no problem.
http://ventral.org/pareview/httpgitdrupalorgsandboxsandervd1787738git
As you should have noticed, PAReview say you should get ride of you master branch: see http://drupal.org/node/1127732
Otherwise, everything looks OK from this test.
As PAReview is expected to be OK to validate permission, I switch Status to "needs work".

I manually looked at your code but don't find much to say: it looks OK for me.

From my point of view: you should add a warning in the README.txt file recalling that one should make sure quick creating fields are OK before creating data as this can block some fields settings configuration afterward. I suggest this because we can presume that many users of your module won't be experimented Drupal developers.

My testing was OK too.
Thank you for this piece of work.

Alexandre

:-)
OK PAReview is fine, and master disappeared from http://drupalcode.org/sandbox/sandervd/1787738.git
I let you complete the project page when you will have some time, and change Status to RTBC.

Regards,

Alexandre

Sorry for setting this back to "needs work" but I found some (more or less major) issues:

major: function quickfields_form_field_ui_field_overview_form_alter()

You are replacing the default field UI submit callback by simply overriding $form['#submit'][0]. This will break if any other module adds a custom submit callback at first position of "#submit" using array_unshift($form['#submit'], 'my_custom_field_ui_submit');.
It would be better to loop search for the name of the default submit callback (using array_search()) and replace it using the returned index.

minor: "package" in .info

Package names shoul be used to group modules with similar purpose (see http://drupal.org/node/542202 somewhere in the middle of that page). As far as I know there is no package named "Field UI" yet, so your module would be alone in that list and might get frightend ;). Consider removing "package" at all (which will list you module under "Other" or use one of the suggested package names from http://drupal.org/node/542202 (for example "User interface").

User interface

Maybe you could attach the checkbox to the input for the name. That would make the extra column obsolete.

Thanks for your patience.

The issues from #10 are all solved, the module works a treat (I am definitely going to use this!) and the code looks great. Alas, when I took out my finest comb and most powerful magnifying glass I did manage to uncover some more minor issues. If these could perhaps be solved this module would shine brighter than a thousand stars.

/**
 * Implements hook_form_FORMID_alter().
 *
 * Adds a quick create checkbox to the 'Manage fields'-tab
 */
function quickfields_form_field_ui_field_overview_form_alter(&$form, &$form_state, $form_id) {
}

• There should be an underscore between FORM and ID.
• The sentence should end with a period.

/**
 * Submit callback of field ui overview form.
 */
function quickfields_form_field_ui_field_overview_form_submit($form, &$form_state) {
}

• This code has been inspired on field_ui_field_overview_form_submit(). Indicate this by adding a link to the docblock like this:

/**
 * Submit callback of field ui overview form.
 *
 * @see field_ui_field_overview_form_submit()
 */

It would also be most pleasant if the text in the readme were reformatted to make everything fit as snugly as possible within 80 characters per line.

Overall my sincere congratulations for this fine piece of programmery!

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Add link to repo