So far it appears the drupal 7 module is able to search all of my fields except for fields within "Field Collections". Would be great if the module supported that.

CommentFileSizeAuthor
#8 Knipsel.PNG16.1 KBRodeo.be
#1 scanner-7-field-collections.patch4.44 KBbrettbirschbach

Comments

brettbirschbach’s picture

brettbirschbach commented
Title: Search does not include Field Collections (Patch Attached) » Search does not include Field Collections
Assigned: brettbirschbach » Unassigned
Status: Needs review » Active
StatusFileSize
new scanner-7-field-collections.patch4.44 KB

I went ahead and implemented a solve for this. In my tests it appears to be working for non-nested field collections. It does not handle the case of field collections within other field collections.

Attaching patch.

**NOTE** This line numbers in this patch may be dependent upon the patch in http://drupal.org/node/1789136 being applied first.

brettbirschbach’s picture

brettbirschbach commented
Title: Search does not include Field Collections » Search does not include Field Collections (Patch Attached)
Assigned: Unassigned » brettbirschbach
brettbirschbach’s picture

brettbirschbach commented
Status: Active » Needs review
zany’s picture

zany commented
Title: Search does not include Field Collections » Search does not include Field Collections (Patch Attached)
Assigned: Unassigned » brettbirschbach
Status: Active » Needs review

+1 on this! Thanks Brett! This works nicely for me. I'm only using the search part though.

brettbirschbach’s picture

brettbirschbach commented

Check https://drupal.org/node/1788182 for a new version of scanner that @ericras is working on, which has pulled in many patches including this one. I have also uploaded a patch to that thread, based on ericras's new version, to support searching fields within nested field collections.

Rodeo.be’s picture

Rodeo.be commented

I still run into this issue - I can select select the fields to be searched under admin/content/scanner/settings

Problem, I cannot select some of the "Fields that can be searched". If I select all the field options, and hit save, none of the fields are saved (page: body , article:title ... are saved but I'm not looking for them)

brettbirschbach’s picture

brettbirschbach commented

Have you tried ericras's dev version? https://github.com/ericras/scanner

Rodeo.be’s picture

Rodeo.be commented
StatusFileSize
new Cannot be selected16.1 KB

Nope, still does not work, see attachment

brettbirschbach’s picture

brettbirschbach commented

Im sorry if I'm just not following, but can you explain again the problem you are having? The screen shot shows checkboxes for fields to search, with one box unchecked. Is that your field collection field? Are you unable to check the box, or does it simply not stay checked when you save?

Rodeo.be’s picture

Rodeo.be commented

I can select the option for the field collection, but when I hit save the selection is not saved.

brettbirschbach’s picture

brettbirschbach commented

Hrmm...not quite sure how to go about fixing this, as I am unable to repro it. I am currently using the version of scanner referenced in #7 and it is working for fields in field collections, as well as fields in nested field collections.

Are you able to repro this on a clean drupal install, such that I could rebuild an environment to repro the issue in?

Also, as a random stab in the dark, do you have language enabled at the field level? All my tests have been with language-neutral fields (using language at the node level).

Rodeo.be’s picture

Rodeo.be commented

Hey HIW, thanks for the support. I reinstalled Drupal on another server, and I don't get the problem anymore. Language is not enabled.

brettbirschbach’s picture

brettbirschbach commented

Not sure what to do about this one if I cannot repro, so if you can come up with a way to repro it reliably that can be passed along to me, I'll take a look.

  • ericras committed 46607e0 on 7.x-1.x 
    Issue #1789964: Search does not include Field Collections
  • ericras committed ce0852c on 7.x-1.x
    Issue #1789964 by HitmanInWis: support searching of fields within nested...
fizk’s picture

fizk commented
Issue summary: View changes
Status: Needs review » Fixed

Eric's GitHub fork has been merged into 7.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

brettbirschbach’s picture

brettbirschbach commented