Create a stable 7 branch release

I've started evaluating this module for use and am willing to work on it to bring it to a usable state. Here is where I've compiled the outstanding patches for 7.x-1.x - http://drupal.org/sandbox/ericras/1960472 or https://github.com/ericras/scanner

The major release blocker I've run into is Pathauto integration: #1766076: Custom alias overwritten on node_save() with alias generated from Path Auto pattern

Awesome ericras, I look forward to seeing a new release of this module. This module, even in its alpha state, has been a huge help for the project I am on.

BTW ericras, if there are any development tasks that you want to split off for another developer to tackle, let me know and I'll see what I can do to carve out some time.

I dealt with the release block mentioned in #1 with this: http://drupalcode.org/sandbox/ericras/1960472.git/commit/49e89cb

@HitmanInWis: I have no further TODOs at this point in time. I've tackled everything that I see that needed to be done. There's still a few TODOs that previously existed in the code dealing with 6->7 deprecated things that I have not looked.

I'm going to try to contact the project maintainers and see what can be done to get my changes brought in.

Have you looked at the issue of searching fields in nested field collections (field collections inside field collections). I implemented the patch to search the first level of field collections, but at the time did not invest the time into going further levels in depth as it was non-trivial. Would be nice to add the feature, at least for my site where we are using field collections somewhat extensively.

@HitmanInWis: No I haven't.

Ok, I may take a stab at it when I get some time.

@ericras

I am uploading a patch to support searching of fields within nested field collections. Replacement of text in field collection fields is not supported yet (wasn't before this patch) but I added a warning message to inform users when they attempt it that it does not work.

I realize I probably should have done this as a pull request on your repository. If you'd like me to do that, let me know. Otherwise, please merge this in, as I started with your repository as of 4/11.

A minor accreditation for the field collection work in the README would be much appreciated.

Thanks!

Note that the patch in #8 also fixes a field sorting issue where all title fields were being sorted to the top of the list of selectable fields.

I previously hadn't checked the Field Collection functionality - but in testing it now both with and without patch #8 it looks like there is some sort of problem. Scanner is only finding results in the first revision of the first Field Collection.

Interesting...I think the version of the field_collection module that I am using actually does not have revisions at all - i.e. my field collection tables dont have a revision ID field. I noticed this a month or so ago when working with a different module that assumed field_collections had revisions. I'll have to take a look.

Re-rolled the field collections patch from #8, starting from your latest git repo. Added support for field_collection revisions, which were added in version 7.x-1.0-beta5. I coded the solution such that older versions of field_collection module that do not support revision_id (7.x-1.0-beta4 and older) still work as well, since field_collection is a module that some people might be scared to upgrade :).

#12 looks good. I figured out the problem with #8 and the current FC release was this line:

format_string('!PREV_ALIAS.entity_id = !FC_ALIAS.!FC_THIS_value AND !PREV_ALIAS.revision_id = !FC_ALIAS.!FC_THIS_value',

that needed to be:

format_string('!PREV_ALIAS.entity_id = !FC_ALIAS.!FC_THIS_value AND !PREV_ALIAS.revision_id = !FC_ALIAS.!FC_THIS_revision_id',

and it looks like you addressed it as you mention in #12.

Eric's GitHub fork has been merged into 7.x-1.x!

If you find any issues, please open a new issue for it.

7.x-1.0-beta1 has been published.

@btopro Please see http://cgit.drupalcode.org/scanner/log/ for changes.