Menu Listchildren

HI Patrick,

Automated Review
Below are listed issues found -

• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• Remove "project" from the info file, it will be added by drupal.org packaging automatically.
• Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically.

Other things looking fine. There are some drupal coding standard issues in your module code.
For automated testing you can use below url -
http://ventral.org/pareview

Hi There,

The link provided for the Git Clone should be 'git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/bripatand/1787684.git menu_listchildren' so that it doesnt require authentication with your details.

.info file refers to a file that does not exist.
files[] = menu_listchildren.test

Mssing return types in docblocks for menu_listchildren_get_children, menu_listchildren_page, theme_menu_listchildren_list

Line 182 the $menu variable does not seem to be used in the scope of the function.

Fix some typos

Everything seems ok now. However, I also see two minor
- Maybe use the placeholder is more easy to understand and create language file for this command: t('Enter') . ' ' . LIST_CHILD_MENU_TOKEN . ' ' . t('to link to page listing the children.')
- And you seem still have a few miss coding standard, please update it

After resolve them, you can do some review as http://drupal.org/node/1410826, and your project will be approved quickly.

If you use following pattern in path "menulistchildren/string" (string can be any thing), then it fails.

typing the URL in browser

the path "menulistchildren/string" is not a valid path so it is normal,
displaying "Not available" message and list of all menu items.

But it displaying only "Not available" message for "menulistchildren/number".
expecting same results.

As far as I tested, it seemed to work as intended. Looks good and it's definitely something I will use in upcoming projects.

It's probably not a deal breaker, but in the future you could consider putting the html in theme_menu_listchildren_list function into a separate template file for easier overriding purposes.

Manual Review

I looked at the code and the functionality. Everything seems to be working fine.
Please modify the project page to be more detailed. Check http://drupal.org/node/997024
Right now the module display sub menu items up to one level. It would be much better if it will show hierarchical structure.

Into Edit menu link Compare this message:
Notice: Undefined index: #description in menu_listchildren_form_alter() (line 53 of [...]\sites\all\modules\menu_listchildren\menu_listchildren.module).

Ehm. Compare only this message in all page.

This looks like a feature that could go into one of the existing module you already mentioned? Module duplication and fragmentation is a huge problem on drupal.org. We prefer collaboration over competition, so please open issue in the queue of one of those modules and try to integrate your stuff there. You should also get in contact with the maintainers and discuss the issue and your possible co-maintainership.

If that fails for whatever reason please get back to us and set this back to "needs review".

Add reviews of other projects

Now it's ok!

Hi @bripatand,

Automatic Review:
It's all right in Coder Module.

Manual Review:
- No LICENSE.txt were found so it is ok.

- Repository is ok.

- I found a issue that should be corrected. I tried to create a menu with path, and some children inside. Then I accessed the parent menu, the one I just created, and every children were listed correctly. After that I set the parent menu as hidden. But when I refreshed the page the title had changed to "Not available".

However if you do the same with any drupal menu, it does not alter the title.

Everything else is working very well. I really appreciated this module!

Renaming modules is currently only possible by creating a new project.

Ok, so I guess your module deserves its own place.

manual review:

1. "define('LIST_CHILD_MENU_TOKEN', '');" all constants defined by your module must be prefixed with your module's name to avoid name clashes.
2. Same for the constants in menu_listchildren.test.

Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

no objections for a week, so ...

Thanks for your contribution, bripatand!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.