over at http://drupal.org/node/177271, drewish explains that there's some weirdness with function _project_release_form_add_version_element() -- it was apparently designed to be able to mark form fields as required, but there was no way to pass in the $required var that would accomplish that. as part of the E_ALL fix there, i've added $required as an optional argument at the end.

question now is, should any of those fields that get built using that function be using that feature? hopefully dww will chime in here, as i don't know enough about the release system to really answer that question with confidence.

Comments

aclight’s picture

aclight commented
Status: Postponed (maintainer needs more info) » Fixed

The code in project_release_validate(), for the D5 version at least, looks like this:

    if (!isset($form_state['values']['version_major']) && !isset($form_state['values']['version_minor']) &&
        !isset($form_state['values']['version_patch']) &&
        (!($form_state['values']['version_extra']) || $form_state['values']['version_extra'] === '')) {
      form_set_error('version_major', t('You must fill in some version information.'));
      // TODO: find a better form value to mark as the error?
    }

So, basically, at least one of the fields must be filled out. So I think the answer would be that no, we don't want to make any of these required.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.