Harden Aloha UI styling

I'll take a crack at this.

Patch attached.

The earlier patch caused an issue with the Spark distro - there was a gap between the tabs and the buttons.

I had to set the aloha surface to use fixed pixels for font-size, otherwise I couldn't set the necessary line-height that would make it work across themes with different base font-sizes.

lgtm, works well, but why is the overflow: visible necessary?

The overflow: visible; was necessary to show the dropdown in certain themes. Sky theme aggressively sets button (and various other elements) to overflow: hidden; which causes the dropdown to be hidden. Forcing this for Aloha has no negative consequence that I can think of so it should be pretty safe.

Fair enough :)

Committed — thanks! :)

- D7: http://drupalcode.org/project/aloha.git/commit/78fdd92
- D8: http://drupalcode.org/project/aloha.git/commit/39c503b

P.S.: I'm deeply sorry, I forgot to attribute you :( I'm relying on Dreditor to generate commit commands, so I'm simply copy-pasting from the browser, but for some reason Dreditor is not yet smart enough to look up the attributions automatically :( As soon as I realized it, I tried to cancel the push, but it already was too late :(

It's a real shame about the git attribution. This is one of my main motivating factors in trying to help out!

I freaking hate the fact that I cannot undo pushes. I understand that d.o must protect contributors' local git clones from becoming messed up, but it *should* be possible. Or even better, the attribution should happen automatically based on the fact that somebody rolled patches in the issue corresponding to the commit.

Because that's another area where git's attribution breaks down: it only allows for *ONE* author. Silly git.

OTOH, you *are* properly credited in the commit message, and any of the "contributor stats" things are actually based on that instead of the git attribution, because git's attribution is so limited.

No biggie. I'll just have to do another patch to make up for it!

Re-do the push? That's impossible AFAIK? Unless you have git superpowers?

And that would result in a *clean* history, *and* git.d.o allows these for non-superpowered-beings such as myself?

git.d.o should definitely allow you to shoot yourself in the foot, if you have that requirement :)

The idea behind not force pushing to a public repo is that someone could have based their work off yours already, and you don't want to cause them a world of pain. In this case I would just leave it, but I do believe that if you just pushed like 2 seconds ago and need to amend a commit message, squash some debugging commits, or otherwise rewrite the history without changing the contents, you (i.e., everyone with commit access) should be allowed to force push to fix their mistake.

#15: RE: "The idea". I know. And I agree.