Part of meta issue #500866: [META] remove t() from assert message focused on the Simpletest module.

In D8 per http://drupal.org/simpletest-tutorial-drupal7#t, best practice is to remove t() from assert messages in tests. When necessary, t() should be replaced with format_string().

There are approximately 35 changes needed in 4 Test files. This issue includes conversion of all format_patch() occurances as well.

CommentFileSizeAuthor
#13 1797514-13-simpletest-t.patch12.51 KBdcam
#6 1797514-6-simpletest-remove-t.patch12.86 KBGaelan
#2 1797514-2-t-simpletest.patch13.96 KBlars toomre

Comments

lars toomre’s picture

lars toomre commented
Assigned: xjm » lars toomre

Patch forthcoming for this one!

lars toomre’s picture

lars toomre commented
Status: Active » Needs review
StatusFileSize
new 1797514-2-t-simpletest.patch13.96 KB

Here is an initial untested patch. This includes some format_string() changes.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

See also #1803674: Remove t() from default test assertions in TestBase class

dcam’s picture

dcam commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

#2 no longer applies due to changes in SimpleTestTest.php.

lars toomre’s picture

lars toomre commented
Assigned: lars toomre » Unassigned
Gaelan’s picture

Gaelan commented
StatusFileSize
new 1797514-6-simpletest-remove-t.patch12.86 KB

Re-roll.

Gaelan’s picture

Gaelan commented
Status: Needs work » Needs review

I am forgetful! :(

Gaelan’s picture

Gaelan commented
Issue tags: -Needs reroll

Tag

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

I reviewed the patch in #6 and it looks good to me. I didn't find any additional t()'s around assert messages.

dcam’s picture

dcam commented
Issue summary: View changes

Added counts from initial patch.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +Coding standards

Tagging coding standards for Jennifer to take a look at.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks! Committed to 8.x. Ready for port!

dcam’s picture

dcam commented
Issue tags: +Novice

Tagging as Novice.

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1797514-13-simpletest-t.patch12.51 KB

Backported #6 to D7.

disasm’s picture

disasm commented

#13: 1797514-13-simpletest-t.patch queued for re-testing.

disasm’s picture

disasm commented
Status: Needs review » Reviewed & tested by the community

Reviewed this patch. It just replaces t() with a plain string for static messages and format_string() for dynamic messages. marking RTBC. I also verified it applies to a clean 7.x.

dcam’s picture

dcam commented

@disasm: Thanks for the review! It will be nice to get one of these committed and closed!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone! Another one bites the dust. Committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fix summary to say Simpletest instead of Statistics.