WimTVpro

Welcome,

please get a review bonus first. Then try to fix issues raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxwimcms1791024git

See also the attachment.

Do not RTBC your own issues, see http://drupal.org/node/532400

1. You must delete the variables when uninstalling the module. E.g. variable_del(htmltag).
2. The following error occurs when we try to enable the module:
   _update_process_info_list()
3. Please check with the Coding Standards. You can use Automated project review on http://ventral.org/pareview

Reverting status. See http://drupal.org/node/532400

1. Api is wim.tv and use in the site test.wim.tv not

Review

Testing was carried out on a brand new install of D7.

Help page

• The links for 'registering an account' and 'License for the Video' appear to be the wrong way around.
• The links to images do not work.

Add new video section

This page is available without setting a username and password. When uploading it runs through the whole upload process - but then errors out with just 'Upload error'.

OK - so I opened an account at Wim TV - added the details to the configuration page - BTW - it may be nice here to get confirmation that the Username and Password are OK.

Then went to the upload page - forgot to enter the title - went to upload a small video - then got the error:

Upload error
Internal Server Error

/usr/share/tomcat6/.wimtv/WebTv/bailey86-2dd51/content/resources/l3vep2sj70eccpaoqjpfda4nm0/tmp/php6Lu3oL (No such file or directory)

You can get technical details here.
Please continue your visit at our home page.

Then added the title - re-uploaded video - then got the same error:

Upload error
Internal Server Error

/usr/share/tomcat6/.wimtv/WebTv/bailey86-2dd51/content/resources/gc8oiul37010tepcepr4mm2su8/tmp/phpWi04r9 (No such file or directory)

You can get technical details here.
Please continue your visit at our home page.

Other points

Why can't ogg video files be uploaded/used?

Code review points

All comments should be in English - see http://drupal.org/coding-standards/docs#general

There should be more comments in the code - comments are a key part of professional code - not a luxury.

wimcms.module

There still seems to be some debug code here at L480 onwards.

BTW - It looks like currently that ventral.org/pareview is not working - i.e. all code is being passed. Please refer to the coding standards at http://drupal.org/coding-standards

The code needs to be indented and to have a single line at the end of each page etc etc. This is difficult to achieve if ventral.org/pareview is not working - but - the 'coder' module is very good and should get you started.

BTW - I use the Emacs Drupal mode - I've blogged about it here - http://www.freewayprojects.com/2011/12/for-all-drupal-devlopers-who-use-... - this mode indents the code properly to the Drupal/Doxygen standards.

Just to help - I installed coder and the following errors were highlighted.

wimcms.module

Line 2: There should be no trailing spaces
/**
Line 48: There should be no trailing spaces

Line 98: There should be no trailing spaces
'access arguments' => array('administer users'),
Line 105: There should be no trailing spaces
'access arguments' => array('administer users'),
Line 113: There should be no trailing spaces
'access arguments' => array('administer users'),
Line 115: There should be no trailing spaces
);
Line 121: There should be no trailing spaces
'access arguments' => array('administer users'),
Line 130: There should be no trailing spaces
'access arguments' => array('administer users'),
Line 138: There should be no trailing spaces

Line 290: There should be no trailing spaces
$getThumbs = $title . "

" . wimcms_getThumbs(FALSE) . "

";
Line 297: There should be no trailing spaces
}
Line 334: There should be no trailing spaces
}
Line 345: There should be no trailing spaces
drupal_add_library('system', 'ui.sortable');
Line 349: There should be no trailing spaces
jQuery(document).ready(function(){
Line 351: There should be no trailing spaces
/*SORTABLE*/
Line 354: There should be no trailing spaces
handle : ".icon_moveThumbs",
Line 357: There should be no trailing spaces
/*SAVE SORTABLE*/
Line 363: There should be no trailing spaces
url: "' . wimcms_checkCleanUrl("admin/config/wimcms/", "wimcmsCallAjax") . '",
Line 366: There should be no trailing spaces
data: "namefunction=ReSortable&ordina=" + ordina ,
Line 368: There should be no trailing spaces
beforeSend: function(){
Line 369: There should be no trailing spaces
jQuery(".icon").hide();
Line 370: There should be no trailing spaces
jQuery(".loader").show();
Line 372: There should be no trailing spaces

Line 375: There should be no trailing spaces
jQuery(".icon").show();
Line 382: There should be no trailing spaces
}
Line 386: There should be no trailing spaces
});
Line 387: There should be no trailing spaces
});
Line 406: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
$jwsrc= drupal_get_path('module', 'wimcms'). "/jquery/jwplayer/player.swf";
Line 423: There should be no trailing spaces
//View Details
Line 470: There should be no trailing spaces
// $output .= "

Categories: " . $cat->categoryName . "

";
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/COLORBOX/JS/JQUERY.COLORBOX.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/COLORBOX/JS/JQUERY.COLORBOX-MIN.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/TIMEPICKER/INCLUDE/JQUERY.UI.WIDGET.MIN.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/TIMEPICKER/INCLUDE/JQUERY.UI.CORE.MIN.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/TIMEPICKER/INCLUDE/JQUERY-1.5.1.MIN.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/TIMEPICKER/INCLUDE/JQUERY.UI.TABS.MIN.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/TIMEPICKER/INCLUDE/JQUERY.UI.POSITION.MIN.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/TIMEPICKER/JQUERY.UI.TIMEPICKER.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/JWPLAYER/JWPLAYER.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/JS/JS.JS
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/JQUERY/JS/JS1205.JS
HIDESITES/ALL/MODULES/WIM_VIDEO_PRO/REQUIRED/FORM.INC
form.inc

Line 7: There should be no trailing spaces
//UPLOAD VIDEO
Line 13: There should be no trailing spaces
function wimcms_TestFileType() {
Line 99: There should be no trailing spaces
function wimcms_upload_validate($form, &$form_state) {
Line 104: There should be no trailing spaces
form_set_error('', t('You must upload a file.') );
Line 121: There should be no trailing spaces
curl_setopt($ch, CURLOPT_HTTPAUTH, CURLAUTH_BASIC);
Line 124: There should be no trailing spaces
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, FALSE);
Line 130: There should be no trailing spaces
curl_setopt($ch, CURLOPT_POSTFIELDS, $post);
Line 141: There should be no trailing spaces
}
Line 143: There should be no trailing spaces
form_set_error('', t('Upload error') . $response);
HIDESITES/ALL/MODULES/WIM_VIDEO_PRO/REQUIRED/BLOCK.INC
block.inc

Line 19: There should be no trailing spaces
'#title' => "Image Logo",
Line 20: There should be no trailing spaces
'#description' => str_replace("##", "Image Logo", $desc),
Line 22: There should be no trailing spaces
'#return_value' => 1,
Line 31: There should be no trailing spaces
'#return_value' => 1,
Line 37: There should be no trailing spaces
'#description' => str_replace("##", "date of birth, sex, name and surname", $desc),
Line 38: There should be no trailing spaces
'#type' => 'checkbox',
Line 39: There should be no trailing spaces
'#return_value' => 1,
Line 50: There should be no trailing spaces
'#return_value' => 1,
Line 59: There should be no trailing spaces
'#return_value' => 1,
Line 67: There should be no trailing spaces
}
Line 71: There should be no trailing spaces
//Info blocco
Line 104: There should be no trailing spaces
if (variable_get("ImageLogoProfile")=="1")
Line 107: There should be no trailing spaces
if (variable_get("pageNameProfile")=="1")
Line 115: There should be no trailing spaces
$arrayjsuser->dateOfBirth . "
" . $arrayjsuser->sex . "
" . "

";
Line 141: There should be no trailing spaces
$block['content']= "

" . wimcms_getThumbs(TRUE, FALSE, FALSE, "block") . "

";
HIDESITES/ALL/MODULES/WIM_VIDEO_PRO/REQUIRED/INSERT.INC
insert.inc

Line 18: There should be no trailing spaces
jQuery(document).ready(function(){
Line 55: There should be no trailing spaces
});
Line 56: There should be no trailing spaces
}
Line 59: There should be no trailing spaces

Line 65: There should be no trailing spaces
jQuery(this).parent().parent().parent().addClass("select");
Line 69: There should be no trailing spaces
var testo = jQuery("#edit-body-und-0-value").val() +"";
Line 82: There should be no trailing spaces
}
Line 89: do not use mixed case (camelCase), use lower case and _
$arrayTestoformat = $build["body"]["#items"][0];
Line 90: do not use mixed case (camelCase), use lower case and _
foreach ($arrayTestoformat as $keyTesto => $testoformat) {
Line 92: use a space between the closing parenthesis and the open bracket
if (isset($risultato[1])){
Line 107: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
$jwsrc= drupal_get_path('module', 'wimcms'). "/jquery/jwplayer/player.swf";
Line 138: There should be no trailing spaces
}
Line 142: do not use mixed case (camelCase), use lower case and _
$build["body"]["#items"][0][$keyTesto] = $testoformat;
HIDESITES/ALL/MODULES/WIM_VIDEO_PRO/WIMCMS.INSTALL
wimcms.install

Line 18: There should be no trailing spaces
),
HIDESITES/ALL/MODULES/WIM_VIDEO_PRO/WIMCMS.SYNC.PHP
wimcms.sync.php

Line 26: There should be no trailing spaces
}
Line 86: There should be no trailing spaces
}
Line 93: There should be no trailing spaces
}
SHOWSITES/ALL/MODULES/WIM_VIDEO_PRO/WIMCMS.JS
HIDESITES/ALL/MODULES/WIM_VIDEO_PRO/WIMCMS.FUNCTION.PHP
wimcms.function.php

Line 14: There should be no trailing spaces
else $sql_where = "";
Line 89: There should be no trailing spaces
else
Line 104: There should be no trailing spaces
else{
Line 110: There should be no trailing spaces
}
Line 112: There should be no trailing spaces
//The video isn't into showtime
Line 121: There should be no trailing spaces
}
Line 152: There should be no trailing spaces
$my_media .= "

" . $form . "

";
Line 170: There should be no trailing spaces
}
HIDESITES/ALL/MODULES/WIM_VIDEO_PRO/WIMCMS.FORM.PHP
wimcms.form.php

Line 9: There should be no trailing spaces

Line 11: There should be no trailing spaces

Line 13: There should be no trailing spaces

HIDESITES/ALL/MODULES/WIM_VIDEO_PRO/WIMCMS.SQL.PHP
wimcms.sql.php

Line 80: There should be no trailing spaces

Line 88: There should be no trailing spaces
$url_post_public_wimtv = str_replace(variable_get('replaceacquiredIdentifier'), $acid, variable_get("urlPostPublicAcquiWimtv"));
Line 116: There should be no trailing spaces
//Richiamo API

Changed status as I forgot to change it before.

You need to set the status to "needs review" if you want to get a review. See http://drupal.org/node/532400

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

name