PhotoLDR is a module that will allow an iOS app to interface with a Drupal site.

The module presents XML based on the site admin's setting.

The module accepts user authentication in POST.

The iOS app can send images and text to the module in POST allowing photo and text contribution to the Drupal site by a user other than Admin. The user must have permission to edit or create the content.

http://drupal.org/sandbox/willisiw/1778338

git clone --recursive --branch 7.x-1.x willisiw@git.drupal.org:sandbox/willisiw/1778338.git photoldr

http://www.photoldr.com

Drupal 7.

Comments

lolandese’s picture

lolandese commented
Status: Needs review » Needs work

Hi Ian,
To start, have a look at http://ventral.org/pareview/httpgitdrupalorgsandboxwillisiw1778338git.

Also, the iTunes app at http://itunes.apple.com/us/app/photoldr/id555194288 is a paid version. Do you have any suggestions for testers what they can do without spending money?

willisiw’s picture

willisiw commented

Coding:

I will work on the coding issues, which appear to be primarily over-indentations. Thank you for the link, it is very helpful.

Cost:
I can provide a limited number of testers with a beta version of the app for testing. It would be an AD-HOC distribution for the purposes of the module testing.

I plan to release a "lite" free version of the app with fewer features, but currently I have not yet decided how exactly to do that.

I also am exploring an Enterprise version for sites with a large volume of nodes

If you are serious about testing the app for the purposes of this module approval, I can provide details on a person by person basis. I need the device UDID of the test applicants. You can send me this in my contact form or by e-mail.

I hope this is helpful and I look forward to testing and more constructive feedback.

Ian

willisiw’s picture

willisiw commented
Status: Needs work » Needs review

I cleaned up the formatting thanks.

I have not seen any requests for beta testing.

Please take a look and give me feedback.

Thank you,

Ian

miloyz’s picture

miloyz commented
Status: Needs review » Needs work

Hi willisiw,

Thanks very much for contributing this nice module and fixing the coding standards errors.

Going through the file photoldr.admin.inc line 18,

  $helptxt = '<p><strong>PhotoLDR must have node types allowed.  Then users permissions must be set to allow users to create content, or the post will fail. </strong></p>';

I noticed this help text description isn't wrapped in a t() function call. It seems other descriptions, help texts seem to have been correctly wrapped in t(), but I guess you should probably take a further look, just to double check.

So far, that's all I could find, but I will keep looking and certainly let you know if I can find anything else.
I hope these comments will help you to improve this nice module.

Cheers!

willisiw’s picture

willisiw commented
Status: Needs work » Needs review

I fixed the one instance of the missing t(). I will continue to look for more of those. I also added the t() function to a few of the labels in a select statement.

http://drupal.org/node/1798254#comment-6824168

I also reran ventral and cleaned up many of the newly revealed formatting issues.

srutheesh’s picture

srutheesh commented

Hi willisiw,

Thanks very much for contributing this good module and fixing the coding standards errors. I could't find any issues in the module, i hope it ready to move as contributed module.

mayank-kamothi’s picture

mayank-kamothi commented
Status: Needs review » Needs work

Hi,

Manual Review:

  • Remove commented code: 
             $handle = fopen("commerce_product_reference.txt", "a");
             fwrite($handle, 'Key: ' . print_r($product, true) . '  ');
             fclose($handle);
            ==================================
            // End if (isset($instances[$k]['widget']['module'])).
  • In photoldr.module 
    $k = (isset($k)) ? $k : 'item';
      $k = is_string($k) ? $k : 'item';
Why are you check $k variable two times it can be checked with only one condition.
  • In .inc file you have provided support for multilingual so better to provide consistency of same feature support to complete module :
    Example : use t() for all text information.
  • Comment missing for hook_page_alter().

    • Mayank Kamothi

    PA robot’s picture

    PA robot commented
    Status: Needs work » Closed (won't fix)

    Closing due to lack of activity. Feel free to reopen if you are still working on this application.

    I'm a robot and this is an automated message from Project Applications Scraper.