This is a sub-task of #500866: [META] remove t() from assert message focused on the Update module.

In D8 per http://drupal.org/simpletest-tutorial-drupal7#t, best practice is to remove t() from assert messages in tests. When necessary, t() should be replaced with format_string().

There are approximately 23 changes needed in 4 Test files. This issue includes conversion of all format_patch() occurances as well (none were needed).

CommentFileSizeAuthor
#4 1798384-4-t-update.patch8.93 KBdcam
#1 1798384-1-t-update.patch10.54 KBlars toomre

Comments

lars toomre’s picture

lars toomre commented
Status: Active » Needs review
StatusFileSize
new 1798384-1-t-update.patch10.54 KB

Here is an initial untested patch for this issue.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

#1 looks good to me. I don't notice any additional t()'s around assert messages.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks! Committed to 8.x. Ready for backport...

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1798384-4-t-update.patch8.93 KB

Backported #1 to D7.

dcam’s picture

dcam commented

#4: 1798384-4-t-update.patch queued for re-testing.

dcam’s picture

dcam commented
Issue tags: +Novice

Tagging as Novice.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

The patch in #4 applies cleanly to 7.x-dev, and I don't see any t()-wrapped assertion messages.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks, and sorry for the delay -- committed to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Modified initial counts.