Remove t() from test asserts in User module [#1798386]

Comment	File	Size	Author
#10	1798386-10-t-user.patch	65.99 KB	dcam
#6	1798386-6-t-user.patch	65.97 KB	dcam
#1	1798386-1-t-user.patch	78.88 KB	lars toomre

Comment #1

lars toomre commented 29 September 2012 at 00:50

Status:

Active

» Needs review

Status	File	Size
new	1798386-1-t-user.patch	78.88 KB

Here is an initial untested patch for this issue. This patch includes format_string() conversions as well.

It also includes coorrections for two test cases where the getInfo strings where being translated with t(). All of the other test cases in this module were correct.

Log in or register to post comments

Comment #2

dcam commented 19 October 2012 at 06:27

Status:

Needs review

» Reviewed & tested by the community

#1 looks good to me. I don't see any additional t()'s around assert messages.

Log in or register to post comments

Comment #3

jhodgdon

she/her

English

commented 19 October 2012 at 22:37

Version:	8.x-dev	» 7.x-dev
Status:	Reviewed & tested by the community	» Patch (to be ported)

Whew, that was a big one. :) Committed to 8.x, ready for backport.

Log in or register to post comments

Comment #4

lars toomre commented 19 October 2012 at 23:09

My guess is that with this commit we are more than 50% way there to eliminating the t() wraps around test assert messages. Thanks for the commits @jhodgdon!

The other big batches of the t() asserts are in the sub-issues to the System module testing the include files. Since I generated most of those patches, it would be great if @dcam or others could review them so that they are ready to be committed as well.

Log in or register to post comments

Comment #5

dcam commented 20 October 2012 at 02:30

I'm not certain, but I think almost all of the issues have had their patches committed to 8.x now. This week I went through the whole list in the meta issue, one-by-one, in order. Last night I reached the end of the list. A few of them had to be skipped and of course many remain to be backported, but other than those that needed rerolling almost all the system tests should be done.

I'll try to get to the rerolled patches tonight if I can, but they may have to wait until tomorrow. We're going out and participating in college homecoming festivities in a few minutes.