Remove t() from test asserts in Xmlrpc module

I checked in XmlRpcBasicTest::testInvalidMessageParsing(). Here's how that array of messages is used:

foreach ($invalid_messages as $assertion) {
    $this->assertFalse(xmlrpc_message_parse($assertion['message']), $assertion['assertion']
}

So that change looks correct to me.

+++ b/core/modules/xmlrpc/lib/Drupal/xmlrpc/Tests/XmlRpcBasicTest.phpundefined
@@ -64,7 +64,7 @@ class XmlRpcBasicTest extends WebTestBase {
     $signature = xmlrpc($url, array('system.methodSignature' => array('system.listMethods')));
     $this->assert(is_array($signature) && !empty($signature) && is_array($signature[0]),
-      t('system.methodSignature returns an array of signature arrays.'));
+      'system.methodSignature returns an array of signature arrays.');

Out of scope here, but I think this should use assertTrue() rather than assert() for clarity. (See TestBase::assert().) Can we file a followup novice issue for that?

All the changes are correct, so RTBC.

Thanks for the explanation in that review xjm. :) This is committed to 8.x.

REMINDER to file that follow-up issue on assertTrue vs assert() mentioned in #2.

Backported #1 to D7.

Oops, deleted an extra ')'. It's strange that it passed the tests locally.

#7: xmlrpc-1798390-7.patch queued for re-testing.

Tagging as Novice.

#7: xmlrpc-1798390-7.patch queued for re-testing.

hi,
the patch seems good :)

Thanks

Thanks for the review, izus!

Thanks all! Committed to 7.x. Another one bites the dust!