Convert javascript_parsed variable to use state system

Tagging...

Tested. Looks good. Thanks!

tagging too.

Actually just realised that we should be cleaning up the variables table on upgrade! :)

So in this case we need a system_update_N function to do a update_variable_del('javascript_parsed')

Thanks for the progress on this.

+++ b/core/modules/system/system.installundefined
@@ -1976,6 +1976,13 @@ function system_update_8021() {
 /**
+ * Clean up javascript_parsed variable.
+ */

Just a minor nitpick but the text here should be "Cleans up javascript_parsed variable." See http://drupal.org/node/1354#functions. Also can you add a doxygen tag to the doc block - so that we can easily find all the state sub system conversions. So the final doc block should lo0k something like this:

/**
 * Cleans up javascript_parsed variable.
 *
 * @ingroup system_upgrade
 */

Leaving at need review so other people will review the patch.

We've decided to namespace the key names so that it's easy to identify the "owner"... so we need to change the variable name to from javascript_parsed to system.javascript_parsed

@LinL thanks for all the work.

In answer to your questions:

Yep it's the old D7 variable - should be left alone.

No need to change the variable name in the code. The reason we have added the system. to the front of the name in the state table is to make it easy to identify the owner - just by looking at the table data. This is not an issue with php variable names.

This is good to go!

Actually the system_update_8022 already needs an update as the routing patch has landed.

Bumped update to system_update_8026. No commit credit necessary. This looks good.

Looks great! Committed and pushed to 8.x (after incrementing that number once again to 8027 after #1798732: Convert install_task, install_time and install_current_batch to use the state system). Thanks!

Also, alex, I decided to credit you in both patches because you're helping mentor people on how to use the state system. :)