This is a sub-task of #500866: [META] remove t() from assert message focused on the new Ban module.

In D8 per http://drupal.org/simpletest-tutorial-drupal7#t, best practice is to remove t() from assert messages in tests. When necessary, t() should be replaced with format_string().

There is just one assert message to change. Patch forthcoming!

CommentFileSizeAuthor
#1 1798960-1-t-ban.patch1.26 KBlars toomre

Comments

lars toomre’s picture

lars toomre commented
Status: Active » Needs review
Issue tags: +Needs backport to D7
StatusFileSize
new 1798960-1-t-ban.patch1.26 KB

Here is an initial untested patch for this module.

Remember that when this is backported to D7, that this module was part of system module in D7 as an include file.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

the only one here to be cleaned

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Assigned: lars toomre » jhodgdon
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Remove t() from test asserts in Ban module » Remove t() from test asserts in Ban module [system module include in D7]
Version: 8.x-dev » 7.x-dev
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Patch (to be ported)

Hooray for one-line cleanups! Committed to 8.x, ready for 7.x backport (or should it just be part of the system module A-Z in D7?).

lars toomre’s picture

lars toomre commented

This one should be part of A-C in D7 if I understand correctly. It was moved from actions.inc as a part of system module to new action module in D8.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 7.x-dev » 8.x-dev
Status: Patch (to be ported) » Fixed
Issue tags: -Needs backport to D7

OK then.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.