The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Another dependency issue I encountered:
admin/structure/mchammer/settings assumes the DS module is loaded.
If not, you get the following error:
Fatal error: Call to undefined function ds_entity_view_modes() in sites/all/modules/mchammer/includes/admin.inc on line 44
Perhaps DS should be a dependency, or these settings hidden if not enabled?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | issues-1800384-1800376.patch | 3.17 KB | lord_of_freaks |
| #3 | Error_when_DS_is_not_enabled-1800384-6547292.patch | 1.79 KB | lord_of_freaks |
Comments
Comment #1
nils.destoop commentedDS used to be a dependency, but we removed it.
Code has been changed. We now get the view modes with entity_get_info().
Comment #2
lord_of_freaks commentedThere are two reference to ds_entity_view_modes yes:
includes/admin.inc:44: $view_modes = ds_entity_view_modes('node');
plugins/display_renderers/panels_renderer_mchammer.class.php:185: $view_modes = ds_entity_view_modes('node');
Anyway great job!!!!!
Greets
Comment #3
lord_of_freaks commentedComment #4
lord_of_freaks commentedPlease ignore previous patch, it´s uncomplete.
This one solves both Error when DS is not enabled and Error when locale module is not enabled issues
Thanks
Comment #5
nils.destoop commentedThis was also fixed :)
Comment #7
tsi commentedSeems like there is something wrong with your project settings - I see you've committed the fix to 7.x-1.x but it is not available when downloading via Drush or in the project page download links.
Check the 'default-branch' tab under the project edit page.
Anyway, thank you for this project, just in time :)
Comment #8
nils.destoop commentedDefault branch was indeed still on master. Changed it to 7.x-1.x. :)