Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Oct 2012 at 23:12 UTC
Updated:
21 Jan 2013 at 20:05 UTC
This module extend SMS Framework, and allows users register, login to site & reset the password by using they phone number. Module has flexible settings for the phone number and user redirection depending on user phone number status (not confirmed, pending, confirmed).
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/VasilyKraev/1802614.git sms_reg
| Comment | File | Size | Author |
|---|---|---|---|
| sms_reg_settings.png | 80.56 KB | VasilyKraev |
Comments
Comment #1
klausiWelcome,
please get a review bonus first. Then try to fix issues raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxvasilykraev1802614git
Comment #2
mschudders commentedManual review
1.1 Ensure your application contains a repository and project page link.
Please add an project page link
1.2 Ensure your project is not a duplication.
It seems there is no module that is doing this (olny snippets)
1.3 Ensure you don't have multiple applications.
Didn't found any.
2. Basic repository checks
2.1 Ensure the repository actually contains code.
Check
2.2 Ensure you are working in a version specific branch.
Ok but please remove the "Master" branch
2.3 Ensure your project contains a minimum of handwritten code.
Seems to be so.
3. Security Review
3.1 Ensure the project does not contain any security issues.
Seems ok
4. Licensing checks
4.1 Ensure the repository does not contain a ‘LICENSE.txt’ file.
Ok
5.1 Ensure the project page contains detailed information.
Looks ok.
5.2 Ensure the repository contains a detailed README.txt.
Contains and looks nice.
5.3 Ensure the code contains a well-balanced amount of inline-comments.
Ok
Automated review:
Please check these issues: http://ventral.org/pareview/httpgitdrupalorgsandboxvasilykraev1802614git
7.1 Ensure you are using Drupals API correctly.
Looks ok.
Recommendation: Maybe put the JS files in a separate folder and them via the .info file ? (as scripts[] = .... or add them via form API)
Comment #3
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)