[META] Views: accessibility review

Views isn't actually even in core yet, so it doesn't really make sense for this to be a major bug report against code that doesn't exist.

Postponing for now. I'll make sure this gets linked in our meta once it's filed.

Wrong postponed. :)

And really this is a critical task when the time comes, not just major.

link to open issues

I added the current open Views accessibility issues to the summary.

Updated issue summary.

.

Oh, that's simply awesome. As a blind user, I will be more than happy to help getting this issue fixed! :-)

Add link to gates

Updated issue summary.

Updated issue summary.

Updated issue summary.

Updated issue summary.

Updated issue summary.

Updated issue summary.

Re-scoping as a meta issue. I have filed issues for accessibility testing we need to do based on the core accessibility gate:

1. #1806278: Test whether Views conforms to WCAG 2.0 and ATAG 2.0
2. #1806288: Fix duplicate ID's in Views HTML structure
3. #1806022: Views' text color does not have sufficient contrast
4. #1806298: Test whether Views' form fields are labeled
5. #1806308: Review Views JavaScript + generic modals for accessibility

The first will require some time investment and expertise, but the next four should be straightforward, so I have tagged those four novice.

Updated issue summary.

Moving to the proper queue so we can legitimately mark this active.

Hi all,

I wonder: what should I use to do this accessibility review?
Can I do my tests against the latest stable views 7.x release?
Or should I use the vdc sandbox with drupal 8.x?

Hi @falcon03,

I'd suggest using the VDC sandbox, because a lot of the code has changed, and so some issues from D7 might have been resolved, while other bugs could have been introduced. There's instructions on cloning the VDC sandbox in the individual issues linked in #9 above. Thanks!

tag

I'm a bit worried about our critical bug count. Views accessibility now adds 4 critical bugs and one critical task to the list. I'm positive that we can find 10 more (and probably more in existing core module or are we really that good already? There are ~80 open issues tagged with accessibility in 8.x, so I guess not.). So the question is, is views accessibility (compared to e.g. accessibility in general) really *that* important right now, in the remaining time before feature freeze?

Considering:
- There are, as already mentioned, many other accessibility issues right now in core according to the tag. Are they all critical?
- Drupal 8 has SERIOUS performance issues right now, we've already identified a number of them but agreed to currently only have 1-2 critical meta issues to track them, see #1744302: [meta] Resolve known performance regressions in Drupal 8. I guess it's similar for other topics too.
- Seeing how long it often takes to properly address accessibility issues, this could easily completely block progress for the remaining feature-freeze time and bring various initiatives to a complete halt, including views itself.

Is that really what we want?

My suggestion would be to have a single meta issue to track them unless they need architectural change that needs to happen before feature freeze to fix them.

@Berdir This was the policy decided upon for these issues, if you disagree please comment in #1810428: [Policy, no patch] Adjust major and critical task thresholds during code thaw. The fact that performance has a different policy is weird, but something to be discussed in that issue. It's quite demotivating for the a11y team, to constantly see people try to demote their issues though.

We can move this task to major, now that we identified some of the major/critical - although I am not sure we have done a full a11y review at all. The better fix would be to have a meta category #1815826: Add "Plan" category to categorize what is called "meta issues" in core right now

Yes, since we're not using this as a catch-all for issues, and instead giving them full critical priority, this shouldn't take up a spot like that.

Updated issue summary.

Updated the summary to clarify the blocking issue here. #1851414: Convert Views to use the abstracted dialog modal effectively prevents us from doing any real accessibility testing since it's not possible to do anything meaningful with a keyboard until that is fixed.

Updated issue summary.

So let's say we're good? From what's left, #933004: Test that all form elements have a title for accessibility covers all that's left from the issue list.