Closed (fixed)
Project:
Quiz
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2007 at 16:17 UTC
Updated:
22 Jun 2014 at 16:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
westwesterson commentedhas this been tested on mysql too? This could potentially break mysql functionality. I think this should be tested before it is committed.
Comment #2
westwesterson commentedI am looking at a solution for this, but it may be best just to wait for the drupal 6 version, which will support any database thanks to the new database extraction layer in D6.
None the less, this is a patch , as of yet untested which proposes to add postgre support. I have left out the update functions from postgre, as there were no previous versions with postgre support, and they would have to be rewritten when the new patch comes out anyhow.
As of yet this is still untested. And this patch also fixes several other problems I found with the delete and install mechanism and table prefixes. This is very much an alpha patch. It will probably need work done, and needs to be tested in both postgre and mysql environments.
Comment #3
senpai commentedI'd say that leaving this one alone for D6 to handle might be the wise move. I don't have a Postgres system to test things on, and the guys at work who do have that capability don't have the time to handle this type of patch. If Drupal 6's database layer can take care of this, maybe it'd be better to move forward on other pressing issues and let this one languish for a few months (or eternity).
Once 2.0 branches, all work on HEAD becomes D6 focused anyway, right?
Comment #4
westwesterson commentedim postponing this
Comment #5
westwesterson commentedupon further review of the Quiz 1.1 this functionality is already in use, if we do not include this feature it is an unexpected regression. So we need to support this, and an upgrade path.
Comment #6
miccil commentedI have a new patch for PostgreSQL support.
It's against current HEAD.
My testing environment is:
Client and developing platform: Windows XP Sp2
Server platform: PostgreSQL 8.0.13 on Gentoo Linux
For my env it seems work
Comment #7
miccil commentedI'm a question.
While I'm checking the code for PostgreSQL porting, I found in quiz.module
the following query
This query produce a PostgreSQL error. I have noted that for the two additional params
that follow the query there's only one % placeholder in the query string.
So I rewrote it as
Is this ok or the correct version is:
Comment #8
westwesterson commentedYour solution seems to work, while i can't verify that this works for postgre sql, it doesn't seem to change anything for mysql users. I am committing this so that it can be tested by postgresql users.
Comment #9
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.