Closed (fixed)
Project:
Examples for Developers
Version:
7.x-1.x-dev
Component:
Other
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
4 Oct 2012 at 21:51 UTC
Updated:
22 Oct 2012 at 18:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
jhodgdonI am working on a patch for this.
Comment #2
jhodgdonHere's a patch for the D7 version. I am not sure if you are working on d8 examples actively, so I didn't look at them yet...
Comment #3
jhodgdonAh, I see from the Examples home page that d8 is not being worked on. Looks like the tests passed... I'll see if I can find one of the people who's been reviewing the corresponding core issues to give it a once-over review.
Comment #4
tstoecklerLooks great!
Comment #5
jhodgdonThanks for the review... I guess I can commit this. Done!
Comment #6
rfayThanks! That went by fast. And such a good thing. That was always so silly having t() in there.
Comment #7
mile23The main advantage of t() being: You get check_plain() for free. You never know what sort of SSS (Same-Site Scripting) attack you might be running on yourself.
Comment #8
jhodgdonThe XSS or SSS argument does not apply to test assertions. They are not using any outside input.
Comment #9
mile23Was a joke. :-)
Comment #10
rfayBut those SSS attacks are the up and coming thing. Got to be careful.