Need admin configurable text on confirm dialog.
ramsamba - October 3, 2007 - 04:17
| Project: | Flag content |
| Version: | 5.x-2.5 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
i must say you've done a good job with this module.
but i wish for the following:
1. be able to change the "flag this" to some other caption. how many people will understand "flag this"? the standard should be "report this". only programmers will understand flag this.
2. there is no textarea for us to fill with a message. this message should be used to inform the user who is flagging the item. the message should appear after the "Are you sure you want to flag...." to clarify to the flagger about what flagging is all about.
even if you can fix item 1 first and later fix item 2, i'll be grateful
for me, going into your code to fix this is a possibility, but the vast majority who want to use this module will not benefit
#1
Please be more descriptive in the title.
Please search the issue queue before filing new issues.
Duplicate of:
http://drupal.org/node/169341 and http://drupal.org/node/90098
#2
it is not a duplicate of both the links you mentioned.
node/169341 is asking for an icon or graphic. i'm not. i'm asking to be able to change the words "flag this" to a string of our choice.
node/90098 is asking for a place for the reporter to add why he thinks the item should be flagged. i'm not. i'm asking for a textarea for the admin to enter information in the admin settings module which will be used below the h1 title of "Are you sure you want....". this "are you sure..." appears after the user has clicked on "flag this".
sorry, i don't want to flame you, but it looks like you jump to conclusions very fast.
#3
The "flag this" is not as cryptic as you think. The module is already live on sites using this text and it is understood (at least in Canada/USA, may be different in other places).
Anyway http://drupal.org/node/169341 would have a theme function where you can override the text any way you want, or with an image if you so wish. So that part can be addressed there. Please comment there with this portion of your issue, since it is all the same.
I changed the title of this issue so it reflects the part about the confirm dialog.
In the future open one issue for each problem/feature request, not many per issue.
Thanks.
#4
firstly, i want to say thank you for doing this free work.
however, i have to still say what i have to say, so please don't take offense.
it was not clear to me that the graphic issue and the text issue were the same; you didn't state that they would be taken care of at one go. in your vision of the solution, it was obvious, but you can't expect me to read your mind.
i beg to differ about the understanding of "Flag this". Programmers have their point of view; i'm a programmer and i have seen people not understand one iota of what is so obvious to us. anyway, i don't want to split hairs over something that's subjective. in my opinion, "report this" is friendlier than "flag this". i called five random non-IT people in the office and asked them about what they understood by "flag this". none of them did.
the best thing to do, again in my opinion, is to allow flexibility by letting the end-user customize it. that way, your module gets top marks every time.
ok, the change in the title sounds good to me. and going forward i'll restrict each post to one issue.
thanks
ps: when can we expect the changes to be implemented?
#5
The graphic change was not clear, and that is why I pointed it out.
Re: flag this wording. You can differ as much as you like, but it is a moot point since we want to allow changing it. So if it is BLAH BLAH in the module, you can override it to anything you want.
As for when this change is expected, the standard answer applies:
- When someone submits a working patch that gets discussed/tested by others
- When a client wants it and pays for the time involved
- When a group raises funds for that feature to get it done
- When we have spare time to do it
#6
whatever...
i've already fixed the code for myself to use. i was concerned about the others.
hope you find someone to pay you for your work.
#7
Do you have a patch you want to share (#1 on the list above).
#8
Not exactly.
Don't have anything to share because I edited the code directly, replacing with my own strings. So this will be useless for non-programmers who only want to change the strings in a textbox.
#9
Attached is a patch that addresses issue 1 in the original feature request. It adds a 'Text Options' fieldset to the admin settings page, and allows you to configure: