If feeds_ui is not enabled, there is no destination for the link to the feed in a "Missing Feeds Plugin" message.

CommentFileSizeAuthor
#10 feeds7-missing-plugin-broken-link-1804674-10.patch1.2 KBmegachriz
#8 feeds-no_link_destination-1804674-8.patch1.11 KBpancho
#6 feeds-no_link_destination-1804674-6.patch1.11 KBpancho
#4 feeds-no_link_destination-1804674-3.patch1.14 KBpancho
#2 feeds-no_link_destination-1804674.patch1.09 KBtravismccauley

Comments

twistor’s picture

twistor commented

What should we do here, just not show the message at all? There won't be a way for the user to deal with it.

travismccauley’s picture

travismccauley commented
StatusFileSize
new feeds-no_link_destination-1804674.patch1.09 KB

Hi twistor,

I was thinking there should be a check if feeds_ui is enabled and if not provide a different message like:

Missing Feeds plugin FeedsZoteroProcessor. To troubleshoot, enable the Feeds Admin UI module and check the settings for zotero_feed at admin/structure/feeds/zotero_feed. Check whether all required libraries and modules are installed properly.

Here's a patch. For a good test case, check out: http://drupal.org/node/1804662 on a clean 7.15 install :].

-Travis

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Active » Needs review
StatusFileSize
new feeds-no_link_destination-1804674-3.patch1.14 KB

A bit less verbose.

Status: Needs review » Needs work

The last submitted patch, feeds-no_link_destination-1804674-3.patch, failed testing.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-no_link_destination-1804674-6.patch1.11 KB

Oh, I'm sorry, that's been a premature version.
Once again: a bit less verbose than #2.

Status: Needs review » Needs work

The last submitted patch, feeds-no_link_destination-1804674-6.patch, failed testing.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-no_link_destination-1804674-8.patch1.11 KB

Oh my, this little fix is really getting embarrassing...
Once again...

Status: Needs review » Needs work

The last submitted patch, feeds-no_link_destination-1804674-8.patch, failed testing.

megachriz’s picture

megachriz
Primary language Dutch
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new feeds7-missing-plugin-broken-link-1804674-10.patch1.2 KB

The patch in #8 missed a closing curly bracket. Here is a new patch. The following message is shown when the feeds_ui module is not enabled:

Missing Feeds plugin FeedsEntityProcessorExample used by the importer "my_importer". Check whether all required libraries and modules are installed properly. Enable the Feeds Admin UI module to check the importer's settings.

  • MegaChriz committed fa5a870 on 7.x-2.x authored by Pancho 
    Issue #1804674 by Pancho, travismccauley, MegaChriz: Fixed broken link...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Committed #10.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.