This is broken in D8 only, possibly due to API changes.

Comments

wim leers’s picture

Priority: Normal » Major
Angry Dan’s picture

After extensive research we can conclude that the problem here is that the included Aloha library has an out of date version of JQuery UI. Upgrading the library to 1.9 fixes the problem.

wim leers’s picture

Title: Link insertion: autocompletion based on node search broken » Link/image insertion: autocompletion doesn't show up
Component: Code » Aloha Editor (upstream)
StatusFileSize
new211.43 KB
new202.8 KB

Wow, really? My investigation led me elsewhere, but it could still be the same root cause.

On D7, it works fine. Both for links and images. So I went for an in-depth comparison. Turns out it's simply a single top declaration in a style attribute not being set…

D7:
aloha-autocomplete-d7.png

D8:
aloha-autocomplete-d8.png

In any case, this is an upstream problem, and it's certainly possible that upgrading to jQuery UI 1.9 fixes this. They've already upgraded to jQuery UI 1.9, I just need to do a new build of our Aloha with new upstream commits to get it as well.

Angry Dan’s picture

Yeah, that sounds like the best course of action. I was surprised to see that the build script works from a specific revision of Aloha - is there a reason that your not working from a specific tag?

No idea what's wrong with the distributed JQuery UI, but once I found that it was .position() I tried running it on other elements on the page and it failed - that's what lead me to try the upgrade.

wim leers’s picture

I *was* working from a specific tag, but then I needed the very latest commits and couldn't wait for a new tag, hence I went for a specific revision. Next build should be based on a tag again :)

wim leers’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.