Ubercart mbe4 Mobile Payment Method

Don't forget to add the PAReview: review bonus" tag as indicated in #1410826: [META] Review bonus, otherwise you won't show up on my high priority list.

I do not have a working Ubercart install right now, so this is just a code walkthrough.

You have a bunch of code formatting problems: http://ventral.org/pareview/httpgitdrupalorgsandboxricoschaefer1799470git

You have an empty README.md file.

Your README.txt is nearly empty. This should at least have a project description.

uc_mbe4.test is empty.

Is mbe4.class.inc a third-part library? If so, you should read the policy on including third-party code.

uc_mbe4_menu() references a file that doesn't exist.

Your access callback should really be identified as such. It is also a good idea to explicitly define a permission and let admins decide whether users can access it.

You create a bunch of variables; you should have a hook_uninstall to clean this up.

Is uc_payment_method_mbe4() a hook? If so, it needs the proper docblock.

You are adding the CSS twice: once in the hook_init() and again in the form_alter

Changing status per comment #3.

Removing review bonus tag, you have not done any manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects.

PAreview brought up some warnings: http://ventral.org/pareview/httpgitdrupalorgsandboxricoschaefer1799470git

If all you are doing is checking the permission you defined, your hook menu can just be

function uc_mbe4_menu() {
  $items = array();
  // Callback-Pfad für Redirect von mbe4
  $items['cart/mbe4/complete'] = array(
    'page callback' => 'uc_mbe4_complete',
    'access callback' => 'user_access',
    'access arguments' => array('complete checkout with mbe4 payment'),
    'type' => MENU_CALLBACK,
  );
  return $items;
}

Since I am not a Ubercart dev, I am not comfortable chaning the review status of this.

I agree with @matthew.donadio about rewriting hook_menu() to handle the permission better. The code in #7 does the same thing as your current code.

There are only a few tiny coding and documentation standards issues left, and they are very minor (e.g. indentation). Those shouldn't block approval.

But something that must be resolved is the branch naming. You have a branch 6.x-1.x and another branch 6.x-1.x-dev. 6.x-1.x-dev is not a valid branch name (see http://drupal.org/node/1015226) and will cause all sorts of problems down the road. As these two branches seem to be identical, you should simply delete the 6.x-1.x-dev branch. Once that is done I think this module is ready to be published and I will set it to RTBC.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

git-command corrected

Closing due to lack of activity. Feel free to reopen.