Taxonomy Orderable Tags adds an autocomplete widget for taxonomy term reference fields that creates a textfield for each entered tag and allows to re-order them by using tabledrag multifield functionality

This module is useful if the order of terms attached to a node is essential and autocomplete / free tagging is required

Project page
Taxonomy Orderable Tags autocomplete widget

GIT
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/AndreyInkin/1804074.git taxonomy_tag_order

Drupal Version
7.x

Comments

d2ev’s picture

d2ev commented

Make sure to review other project application and get a new review bonus to get this finished faster.

Drupal Code Sniffer has found some issues with your code.....


FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 13 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: .../sites/all/modules/pareview_temp/test_candidate/taxonomy_tag_order.info
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 7 | ERROR | It's only necessary to declare files[] if they declare a class or
   |       | interface.
--------------------------------------------------------------------------------


FILE: ...ites/all/modules/pareview_temp/test_candidate/taxonomy_tag_order.module
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AND 1 WARNING(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
   5 | WARNING | Line exceeds 80 characters; contains 94 characters
  82 | ERROR   | Spaces must be used to indent lines; tabs are not allowed
  82 | ERROR   | Line indented incorrectly; expected 4 spaces, found 1
  90 | ERROR   | Closing brace indented incorrectly; expected 1 spaces, found 4
  98 | ERROR   | Function comment short description must end with a full stop
 132 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------
Andrey Inkin’s picture

Andrey Inkin commented

Thanks! Somehow my coder installation didn't detect most of thos, but all fixed now...

cubeinspire’s picture

cubeinspire commented
Status: Needs review » Reviewed & tested by the community

Everything works as expected.
Syntax is ok (ventral.org)
Branch is ok.
The code size is just above the limit (120 lines 5 functions).
There is no security issue neither, check_plain() is applied on the output, addTag('term_access') also...
I guess this is RTBC.

cubeinspire’s picture

cubeinspire commented
Status: Reviewed & tested by the community » Fixed

Hi again !

I've found a compatibility issue with Entity module and created an issue here: http://drupal.org/node/1858622
But this is not a blocker issue.

As there have been no opposition to my last review I guess this is RTBC.

Thanks for your contribution, Andrey Inkin!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

required links added