Background Stretcher (Full-screen background slideshow)

Very cool concept.

Please include a README.txt file - maybe include usage example therein.

Did not find an warning or errors in code using the coder module (http://drupal.org/project/coder).

correct html

I like the concept of this as I've used this full screen background style on other sites, except implemented within the theme versus using a module.

Overall looks good, but can I ask what are the differences between this module and the Backstretch module that is already available here? http://drupal.org/project/backstretch

Aside from using a different JS library they seem to do the same thing. Any marked differences that prompted you to write a separate module versus collaborating on an existing one?

Hi ymakux,
Your project is interesting :-)

• You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch.
• Your next branch name is 7.x-1.0 and for additional resources please see the documentation about release naming conventions and creating a branch or tag in git.
• Add to info file link to your configuration - then you can view this on the list of modules page (this is a very helpful new feature in D7):
  configure = admin/structure/bgstretcher
  You can see more information here: http://drupal.org/node/542202

October 10, 2012 - Update (more info)

• I think that a better way of creating administration is include description to
  

  function bgstretcher_menu() {
    $items = array();
    
    $items['admin/structure/bgstretcher'] = array(
      'description' => '............',

  because for user is this important place for description.

• You have in your module external library, but you can include 3rd party libraries only if you ask for an exception.

Hi ymakux,

I thought I'm on 7.x-1.0 now. Since I'm not .git guru, I need a time to figure out how to remove 'master' branch. BTW, I use TortoiseGit :)

I don't use TortoiseGit , but I can write you the necessary steps:

I see that you updated the files in the branch 7.x-1.0

1. You need to be in the branch 7.x-1.0
2. from branch 7.x-1.0 to create a new branch 7.x-1.x
3. check if you have the files in the branch 7.x-1.x
4. preset the 7.x-1.x branch as default
5. delete all files from the master branch and branch 7.x-1.0
6. delete the master branch and branch 7.x-1.0

then if you believe that this brancch is already stable you can add the tag 7.x-1.0

I hope I helped you

Hi ymakux;

You preset please the 7.x-1.x branch as default: http://drupal.org/node/1659588

Thank you

OK :-)
Good luck

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

correction of description

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  ./bgstretcher.api.php:                          PHP script, ASCII text, with CRLF, CR line terminators
  ./bgstretcher_context_reaction_bgstretcher.inc: PHP script, ASCII text, with CRLF line terminators
  bgstretcher.api.php
  bgstretcher_context_reaction_bgstretcher.inc
  

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

The online version works for me: http://ventral.org/pareview/httpgitdrupalorgsandboxymakux1806328git

Yes, but you should remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

Why?

And "won't fix" is the appropriate status if the application was not finished for whatever reason.

Actually, Drupal code sniffer has been merged into coder. So there are only 2 tools left: coder sniffer for coding standards and pareview.sh for other project application checks. If you found any bugs please report them in the coder or pareview.sh issue queue. Usually they do not throw a lot of false positives and have proven to represent the Drupal coding standards very well.

Oh, and I also updated the documentation. Now that we can delete the master branch on drupal.org it does not make sense to keep it: http://drupal.org/empty-git-master

What errors are you getting while trying to delete the master branch?

Did you try these commands?

git branch -D master
git push origin :master

what shall I do now?

The master branch is no longer there, so that's done now :)

Hi, why can't we edit elements added to slideshow in URL sourse?

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

review link added