Site Review

While waiting for manual review of your module please correct issues found by automatic review:
http://ventral.org/pareview/httpgitdrupalorgsandboxddoak1812488git

What's more consider participating in Review bonus to get your application reviewed sooner.

Please add README.txt

This sounds an interesting module, solving interesting problems, in a local environment,

Some questions:

• Some of the tasks done regarding security are already possible to be checked using security review module (http://drupal.org/project/security_review). Could you consider integrate the module with yours in order to running its tests instead of creating new tests, avoiding work duplication?
• Hacked tests the presence of changed code. It could also be a good candidate for integration. Would it be possible to integrate?

You should review Coding standards It is possible still to find several mistakes in http://ventral.org/pareview/httpgitdrupalorgsandboxddoak1812488git

I installed the module and found some problems:
When listing the reports, the table does not seems to be rendered correctly and I get the following errors:

Warning: Invalid argument supplied for foreach() in theme_table() (line 1907 of /Users/Hernani/Sites/acquia-drupal/includes/theme.inc).
Warning: Invalid argument supplied for foreach() in theme_table() (line 1885 of /Users/Hernani/Sites/acquia-drupal/includes/theme.inc).
Warning: Invalid argument supplied for foreach() in theme_table() (line 1907 of /Users/Hernani/Sites/acquia-drupal/includes/theme.inc).
Warning: Invalid argument supplied for foreach() in theme_table() (line 1907 of /Users/Hernani/Sites/acquia-drupal/includes/theme.inc).
Warning: Invalid argument supplied for foreach() in theme_table() (line 1907 of /Users/Hernani/Sites/acquia-drupal/includes/theme.inc).
Warning: Invalid argument supplied for foreach() in theme_table() (line 1885 of /Users/Hernani/Sites/acquia-drupal/includes/theme.inc).
Warning: Invalid argument supplied for foreach() in theme_table() (line 1907 of /Users/Hernani/Sites/acquia-drupal/includes/theme.inc).
Warning: Invalid argument supplied for foreach() in theme_table() (line 1907 of /Users/Hernani/Sites/acquia-drupal/includes/theme.inc).

After installing, when I run Drush I get the following error:

PHP Fatal error:  Class 'SiteReviewCliReport' not found in /Users/Hernani/Sites/acquia-drupal/sites/lvjumpstart.localhost/modules/site_review/site_review.drush.inc on line 12
Fatal error: Class 'SiteReviewCliReport' not found in /Users/Hernani/Sites/acquia-drupal/sites/lvjumpstart.localhost/modules/site_review/site_review.drush.inc on line 12
Drush command terminated abnormally due to an unrecoverable error.                                                                                    [error]
Error: Class 'SiteReviewCliReport' not found in
/Users/Hernani/Sites/acquia-drupal/sites/lvjumpstart.localhost/modules/site_review/site_review.drush.inc, line 12

Hey,

The problem seems to be in

function site_review_drush_command() {
  return SiteReviewCliReport::getDrushCommand();
}

When it is executed the classes are still not loaded. Tested with drush 5.5 and drush 5.7

The content of site_review_security.config.inc should all go into the existing security review module. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the security_review issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

And I think the remaining part of this module should be called performance_review.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

A review project links