Clan Rank and Decorations

Hi Gflamino,

- Your project is quite big, but the information we can read in your sandbox page is too little, please update it to help user easy to understand what is this project work for.
- Please check your project about Drupal Coding standard

Regards,
Steve Jan

Hello,

I did an automated project review for you, and i got some errors and warnings, please try to fix them.
http://ventral.org/pareview/httpgitdrupalorgsandboxgflamino1803994git

Good Luck.

Database tables
One thing with your db table names is that they are not all prefixed with your module name. I can see why you have probably not done this due to the length of the module. Maybe renaming the module to an acronym so its shorter? - http://drupal.org/node/2497#naming

Suggestion
I like the idea of being able to load dummy data, I wonder if there is a way to extend devel and devel generate. So you split your project into 2 modules. 1 for the actual functionality and one as a devel clan generate module. I think that would be awesome.

Spacing
There seems to be a lot of spacing between some array elements keys and values such as line 25 and 26 of your module file

      'title'          => t('View Clan Users'),
      'description'    => t('Allow users to view member details.'),

I believe this should just be one space either side of =>

Errors after install
Install went fine but when I went to the following URL I got the following error messages

clan_rank_and_decorations/member/roster

Notice: Undefined variable: default_value in clan_rank_and_decorations_roster() (line 487 of /vagrant/websites/blank.dev/public_html/sites/all/modules/contrib/clan_rank_and_decorations/clan_rank_and_decorations.members.inc).
Warning: Invalid argument supplied for foreach() in form_type_tableselect_value() (line 2331 of /vagrant/websites/blank.dev/public_html/includes/form.inc).

I think this may have been related to my site only having a single user (uid: 1)

When I added a user to the clan the default image was missing /sites/default/files/clantastic/images/a0.png

Git folder in repo
There seems to be a folder "git.drupal.org sandbox" in the repo when I cloned it.

Overall
Other than the above the module works really well, the code looks good overall. My only suggestions would be to show the users clan info, rank, awards on their user profile maybe create a tab on their user page.

Remove the excess whitespace, rename the module or database tables and get rid of the "git.drupal.org sandbox" directory and I think its all good.

Please have a look some code observation of technical point of view

db_update('system')
     ->fields(array('weight' => 999))
     ->condition('name', 'clantastic')
     ->execute();

This application is not fixed? See http://drupal.org/node/532400

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

I have manually reviewed the module there are a few items that I noticed:

• The functions to uninstall should be included in module_uninstall() wihtin the MODULE.install file, not a separate file. Note that tables created during installation are removed automatically by the uninstaller.
• "module_load_include('inc', 'clantastic', '/includes/custom_functions');": no need to use module_load_include as you are including files from your own module which you already know where they are. Use something like require_once 'includes/custom_functions.inc';
• clantastic_fetch_clantastic_member_value(): Do not use db_select() for simple static queries, use db_query() instead. See http://drupal.org/node/310075 . Also elsewhere within the module files.

There are numerous spelling errors in the inline comments. In clantastic.admin.inc:

• Line 18: * Award id to be editted. (should be edited)
• Line 35: * Award id to be editted. (should be edited)
• Line 38: // Get memeber details. (should be member)
• And others

When editing a member, I received the following errors:

• Notice: Undefined variable: default_value in clantastic_member_detail_edit() (line 99 of /sites/all/modules/contrib/clantastic/clantastic.members.inc).
• Warning: Invalid argument supplied for foreach() in form_type_tableselect_value() (line 2335 of /includes/form.inc).

(See attached Image)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

added Configuration how-to instructions.