Postponed
Project:
Aloha Editor (obsolete)
Version:
8.x-2.x-dev
Component:
Aloha Editor (upstream)
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Oct 2012 at 10:40 UTC
Updated:
31 Oct 2012 at 01:57 UTC
Jump to comment: Most recent file
Comments
Comment #1
quicksketchI've revived that above issue with a new approach that looks like it's going to move forward because it both fixes an existing bug and solves problems for other libraries. However for D7, the patch is not back-portable. For D7 and Spark, I suggest we simply use a 3 line workaround (regex). See patch.
We could use this for both D8 and D7 in the mean time, but I think #1664602: Allow attributes to be passed to drupal_add_[css|js] (SRI) will make it unneeded for D8.
Comment #2
quicksketchPatch.
Comment #3
wim leers100% agreed with #1.
#2 committed to D7 & D8 (with only s/temporarily/temporary):
- D8: http://drupalcode.org/project/aloha.git/commit/af003fa
- D7: http://drupalcode.org/project/aloha.git/commit/1563e28
(And DAMMIT, I forgot to use git attribution this time :( I'm so sorry, @quicksketch!)
Moving to D8, marking as postponed. Once they've gotten rid of this upstream, I'll remove the attribute from the Aloha module in both D8 and D7 and mark this issue as fixed. Note that when that happens, the
'defer' => TRUEon aloha.js should be removed.Comment #4
wim leersHowever, the patch in #2 did not yet get rid of the
data-aloha-defer-initattributes being added "the old school way", so I can at least attribute that to @quicksketch :)- D8: http://drupalcode.org/project/aloha.git/commit/e11bea0
- D7: http://drupalcode.org/project/aloha.git/commit/29a8780
Comment #5
wim leers.