Split off from http://drupal.org/node/172456
When clicking "Add item", the navigation block no longer marks Menu as the active menu item, so the sub-nav is lost. The breadcrumb is similarly messed up; it only goes to Home > Administer > Site building, so there is effectively no way to get back to the parent menu from this page.
I don't know the menu system well enough to find a good way to reset the breadcrumb trail, without making customize-menu a local task of admin/build/menu.
I guess what could be done is to build and active trail based on admin/build/menu and then set_active_trail to that?
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | menu-customize.patch | 8.23 KB | fwalch |
Comments
Comment #1
fwalch commentedI don't really understand why "menu-customize" is necessary. Why not just use "admin/build/menu/..." instead of "admin/build/menu-customize/..."? That'd be the easiest solution imho.
The attached patch changes all appearances of "menu-customize" to "menu". The breadcrumb and the sub-navigation are then displayed correctly. Is this an appropriate solution?
Comment #2
catchstatus
Comment #3
panchoI don't like "menu-customize" either, as it is only an ugly stop-gap-measure. But we need to do this correctly.
This way we'd get a problem with menus that are called "add" or "settings" as their paths would conflict with the paths of the local tab, plus potentially any contrib paths that are added directly under admin/build/menu.
As this is "just" cosmetics but needs to be revisited, I move this issue to D7.
Comment #4
pwolanin commentedYes, Pancho is correct. I put that ugly path there since otherwise we'd have to start blacklisting menu names (see: http://drupal.org/node/204415).
We could fixup the BC (see above issue) or feel free to think of a better way to do this. Otherwise this will be closed as "by design"
Comment #5
pwolanin commentedI had code here for D6: http://drupal.org/node/204415#comment-709838
but it was rejected by Gabor just below for D6 - could probably be ported forward to D7 if you want to at least make the BC work better.