Use proper stylesheet import for minnelli

Reviewed and tested. Works very nicely.

I do not have time now to check for the RTL version, but it might not work from what I think now. AFAIK, RTL CSS files are looked up from the same directory, so style-rtl.css might not be included this way. Care to test?

Look at how drupal_add_css() adds RTL sheets and/or try whether adding an RTL language using Minnelli loads in Garland's style-rtl.css too.

In the attached screenshot, you'll see that garland/style-rtl.css is correctly loaded when using a right-to-left language.

So then, if Drupal itself figures it out that the Garland style-rtl.css should be added to the page, there is absolutely no need for the empty minelli-rtl.css as added by this patch, because it has no use as far as I see.

Good point, here's the patch without minnelli-rtl.css.

Thanks, committed.

I realized a few minutes ago that I actually did not remove style.css and style-rtl.css with this commit. After I removed and tried to test something else, it turned out that this broke the maintenance pages (install, update). The maintanance.tpl.php file in misc tries to directly load the style.css from the theme, which is not there after this patch in Minnelli. It would be quite ugly to use minnelli.css instead, as it would tie the "generic" tpl.php to Minnelli. The theme_maintenance() function and its friend theme_install_page() has Minnelli specific details, so it could add the minnelli.css, but that does not help of course, as it does not make the garland style.css available (as we depend on the CSS fallback discovery with this patch, and that does not work there), so we would need to add garland's style.css manually. I am not sure this would look nice... Anyway, as with this patch, Drupal is clearly broken, I needed to roll it back.

The root of the problem is that they are hard coded for style.css and that they don't run the usual CSS detection code as themes do.

Whoops, didn't know this was here.

Sub-theming works fine with maintenance theming, so here's the patch for Minnelli.

Seems to be the same as the one I posted. This patch works as expected. When using a right-to-left language, it imports Garland's style-rtl.css without any problems... What I'm concerned with, however, is the issue that Gábor brought up earlier.

Rob Loach: The maintenance theming changed since I originally committed this issue, so if your *testing* shows that it still works with the new patch applied to the newest dev version, then we are fine. Did you test?

Sry Rob. Wasn't sure yours would apply and I already had the patch. :) They are pretty much the same and you were here first so credit to Rob.

Looks like it's ready to go in.

Actually, the credit all goes to Crell and you. I didn't write the patch, I just updated it to HEAD ;-) .

Committed this one, thanks. I hope we will not find more bugs with this later this time.