After the change from using a textarea to a div, the content isn't run thrugh the plugins makeClean functions, causing editing markup to end up in the content.

I've filed an issue upstream: https://github.com/alohaeditor/Aloha-Editor/issues/772

The attached patch is a quick hack workaround, so Aloha.module isn't rendered useless until it's fixed upstream.

(What's the preferred status for "waiting for upstream"?)

CommentFileSizeAuthor
#3 aloha-makeClean-1816276-3.patch761 bytesxen
aloha-makeClean.patch656 bytesxen

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks! :)

The component is correct, the status: not sure. Let's give them 48 hours to merge it upstream, then I'll do another build of Aloha. If by that time they haven't merged it yet, then I'll commit your work-around.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs work

P.S.: your work-around should link to this issue specifically, with a "@todo: work-around …" message, so we don't forget to get rid of it.

xen’s picture

xen commented
StatusFileSize
new aloha-makeClean-1816276-3.patch761 bytes

P.S.: your work-around should link to this issue specifically, with a "@todo: work-around …" message, so we don't forget to get rid of it.

Heh, create the hack, create the issue, update the hack, attach the patch. A bit back and forth. :-)

New patch attached.

Anyway, seems that upstream thinks we should use Ephemera instead. If that works, we can close this one. Guess I'm the only one using makeClean at the moment?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

ephemera is brand-spanking-new :) It's superior to what was there before. If you sign the Aloha CLA (Contributor License Agreement), then you'll end up on the mailing list, where this was announced a few weeks ago.

xen’s picture

xen commented

It does seem rather neat, but is it in aloha.module, or when will we see it?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

aloha.module has it; the latest alpha contains 0.22.1; the dev snapshot contains an even newer version.