The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.according to:
http://drupal.org/coding-standards
Files should be saved as Unix filetype, not windows. Windows uses an older format (\r\n) for line endings. Unix and most modern PHP editors tend to use Unix newlines which are just "\n". This means if I (for example) edit the module and then go to do a cvs diff to make a patch, cvs thinks the entire module has changed simply because Zend Studio uses Unix Filetypes and the newlines have all changed...
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | guestbook_unix_eol_DRUPAL-5--1-0.patch | 94.28 KB | m1mic |
| #1 | guestbook_unix_eol.patch | 95.66 KB | m1mic |
Comments
Comment #1
m1mic commentedThis patch converts the Windows style line endings (\r\n) to the Unix style line endings (\n) on the following files:
I applied the patch against DRUPAL-5 in my contributed modules folder (not in the Guestbook folder)
Comment #2
m1mic commentedIn case anybody needs a version of the previous patch for DRUPAL-5--1-0, here it is.
Comment #3
sunAdditionally, character encoding of guestbook files is Latin1 and not UTF-8.
I bet that many bug reports and support issues for guestbook are also caused by wrong file formats.
Patch in http://drupal.org/node/208389 suffers from this issue, too.
Comment #4
sunyay! After cleaning up the issue queue, I need to bump this issue to bring it into my attention. Sorry for that. :)
Comment #5
sunComment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.