The tests should go into downloads_distributions.feature and check:
- navigate Home page -> D&E -> Distributions tab
- check that page exists
- check that filtering works should go to solr tests
The tests should go into downloads_distributions.feature and check:
- navigate Home page -> D&E -> Distributions tab
- check that page exists
- check that filtering works should go to solr tests
Comments
Comment #1
eliza411 commentedIt would be really helpful on these to start out a test request with the actual feature description and business value.
Comment #2
eliza411 commentedMaybe something like:
The filters should get matrixed into the solr tests and tagged @downloads
Comment #3
tvn commentedI've added the file (http://drupalcode.org/project/doobie.git/commit/05aedab)
For now I added tests to just check if pages like "New Distributions" show at least some distributions. Later we might expand them to check if they really show new ones.
Filters test should go to the solr folder with the rest, so not into this file.
Comment #4
eliza411 commentedOverall, looking good, but again most of these are missing their When statement (It's been included in the Given as an And) and there are some white space issues ... see for details.
See http://drupal.org/node/1826164#comment-6669430
Comment #5
kssundar commentedI think we can write scenario outline similar to this - http://drupal.org/node/1826164#comment-6670962
Any thoughts?
Comment #6
tvn commentedFixed When and whitespace (I hope) http://drupalcode.org/project/doobie.git/commit/792bc2b
Comment #7
kssundar commentedUpdated feature - http://drupalcode.org/project/doobie.git/commit/c8aae9e
Removed scenarios and added scenario outline
Comment #8
eliza411 commentedThis looks good. I removed the @wip tag, and this is ready to pull into 7.x
Comment #9
kssundar commentedPorted to 7.x - http://drupalcode.org/project/doobie.git/commit/945b5f3
Comment #10
eliza411 commentedHere's what I'm seeing when I run the @downloads tests. I doubt I'll get to hunting down the reason for each any time soon but am wondering if you're seeing the same. Some of the errors are 500s so I'm suspecting mostly broken site issues (and the devs have not pronounced this ready, so it's premature to open issues for those).
The unimplemented step looks like the only concern to attend to for now.
Comment #11
eliza411 commentedForgot to set this to needs work.
Comment #12
kssundar commentedThe undefined step definition is part of #1826158: Update downloads_modules.feature file. As 6.x was still under review, i did not port it to 7.x
Comment #13
kssundar commentedThis is ported to 7.x as well - http://drupalcode.org/project/doobie.git/commit/d340494
Comment #14
kssundar commentedAdjusting title
Comment #15
eliza411 commentedOkay. Marking this fixed and planning to do all the updating as part of the feature set review.
Comment #16
eliza411 commentedreally marking fixed.
Comment #17.0
(not verified) commented.