The tests should go into downloads_distributions.feature and check:

- navigate Home page -> D&E -> Distributions tab
- check that page exists
- check that filtering works should go to solr tests

Comments

eliza411’s picture

It would be really helpful on these to start out a test request with the actual feature description and business value.

eliza411’s picture

Maybe something like:

Feature: Find Drupal distributions
  In order to avoid re-inventing the wheel
  As a site builder
  I need to find Drupal distributions that meet my site goals

The filters should get matrixed into the solr tests and tagged @downloads

tvn’s picture

Status: Active » Needs review

I've added the file (http://drupalcode.org/project/doobie.git/commit/05aedab)

For now I added tests to just check if pages like "New Distributions" show at least some distributions. Later we might expand them to check if they really show new ones.

Filters test should go to the solr folder with the rest, so not into this file.

eliza411’s picture

Status: Needs review » Needs work

Overall, looking good, but again most of these are missing their When statement (It's been included in the Given as an And) and there are some white space issues ... see for details.

See http://drupal.org/node/1826164#comment-6669430

kssundar’s picture

Status: Needs work » Needs review

I think we can write scenario outline similar to this - http://drupal.org/node/1826164#comment-6670962

Any thoughts?

tvn’s picture

kssundar’s picture

Issue tags: +sprint 15

Updated feature - http://drupalcode.org/project/doobie.git/commit/c8aae9e

Removed scenarios and added scenario outline

eliza411’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

This looks good. I removed the @wip tag, and this is ready to pull into 7.x

kssundar’s picture

Status: Patch (to be ported) » Needs review
eliza411’s picture

Here's what I'm seeing when I run the @downloads tests. I doubt I'll get to hunting down the reason for each any time soon but am wondering if you're seeing the same. Some of the errors are 500s so I'm suspecting mostly broken site issues (and the devs have not pronounced this ready, so it's premature to open issues for those).

The unimplemented step looks like the only concern to attend to for now.

29 scenarios (9 passed, 20 failed)
151 steps (76 passed, 53 skipped, 2 undefined, 20 failed)
0m16.432s

You can implement step definitions for undefined steps with these snippets:

  /**
   * @Given /^I should see at least "([^"]*)" links under "([^"]*)"$/
   */
  public function iShouldSeeAtLeastLinksUnder($arg1, $arg2) {
    throw new PendingException();
  }
eliza411’s picture

Status: Needs review » Needs work

Forgot to set this to needs work.

kssundar’s picture

Status: Needs work » Needs review

The undefined step definition is part of #1826158: Update downloads_modules.feature file. As 6.x was still under review, i did not port it to 7.x

kssundar’s picture

kssundar’s picture

Title: Create tests for /downloads/distributions » Create tests for /downloads/distributions (downloads_distributions.feature)

Adjusting title

eliza411’s picture

Okay. Marking this fixed and planning to do all the updating as part of the feature set review.

eliza411’s picture

Status: Needs review » Fixed

really marking fixed.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

.