I have RTFM, but I can not find a reference to what version of the Unsupported and Obsolete OAuth Common the Twitter sub-modules twitter_actions, twitter_post, and twitter_signin are dependent on.

http://drupal.org/project/oauth_common

Is Twitter really dependent on oauth_common? Or was this http://drupal.org/node/1255510#comment-5275812 (I'm guessing the fix) never actually applied?

Last I installed (and succfully configured) the twitter module was ~18 months ago, so I know it can be done, but....

Best,
Sam

Full drush stream:

The following projects have unmet dependencies:
twitter_actions requires oauth_common
twitter_post requires oauth_common
twitter_signin requires oauth_common
Would you like to download them? (y/n): n
Module twitter_actions cannot be enabled because it depends on the following modules which could not be found: [error]
oauth_common
Module twitter_post cannot be enabled because it depends on the following modules which could not be found: [error]
oauth_common
Module twitter_signin cannot be enabled because it depends on the following modules which could not be found: [error]
oauth_common
[sam@localhost upcex]$ drush pm-info twitter
Extension : twitter
Project : twitter
Type : module
Title : Twitter
Description : Adds integration with the Twitter microblogging service.
Version : 6.x-3.0
Package : Other
Core : 6.x
PHP : 5.1
Status : not installed
Path : sites/all/modules/twitter
Schema version : no schema installed
Requires : none
Required by : twitter_actions, twitter_post, twitter_signin

[sam@localhost upcex]$ drush en oauth
The following extensions will be enabled: oauth
Do you really want to continue? (y/n): y
oauth was enabled successfully. [ok]
[sam@localhost upcex]$ drush pmi oauth
Extension : oauth
Project : oauth
Type : module
Title : OAuth
Description : Enable the world wide standard OAuth for authentication.
Version : 6.x-2.02
Package : Other
Core : 6.x
PHP : 4.3.5
Status : enabled
Path : sites/all/modules/oauth
Schema version : module has no schema
Requires : none
Required by : none

[sam@localhost upcex]$ drush en twitter
The following extensions will be enabled: twitter
Do you really want to continue? (y/n): y
twitter was enabled successfully. [ok]
[sam@localhost upcex]$ drush pmi twitter_actions
Extension : twitter_actions
Project : twitter
Type : module
Title : Twitter actions
Description : Exposes Drupal actions to send Twitter messages.
Version : 6.x-3.0
Package : Other
Core : 6.x
PHP : 4.3.5
Status : not installed
Path : sites/all/modules/twitter/twitter_actions
Schema version : no schema installed
Requires : twitter, oauth_common
Required by : none

[sam@localhost upcex]$ drush dl oauth_common
There are no releases for project oauth_common.
Choose one of the available releases for oauth_common:
[0] : Cancel
[1] : 6.x-2.x-dev - 2011-Feb-25 - Development
[2] : 6.x-1.x-dev - 2011-Feb-25 - Development

0
Cancelled

CommentFileSizeAuthor
#11 twitter-n1829712-11.patch994 bytesdamienmckenna
#10 twitter-n1829712-10.patch906 bytesdamienmckenna

Comments

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Active » Fixed
  • You need to download the OAuth (>= 3.x), which contains the OAuth Common module.
  • Enabling Twitter will enable the required OAuth Common module. No config required.

I get that this is a bit confusing because we depend on oauth_common module which is now in the OAuth project. Perhaps you can suggest a better way for us to word this in the README.txt?

Please add a comment or patch to #1820128: Improve setup documentation for Twitter module with your suggested improvements.

Michael-IDA’s picture

Michael-IDA commented

Hi Chris,

Thanks, there are just too many references to what twitter wants. Instead of trying to define it (yet again) in documentation. Please add the appropriate:

dependencies[] = exampleapi (1.x)

to the .info file.

If I don't typo this, for Twitter version 6.x-3.0, that would be:

dependencies[] = oauth (>3.0)

But it's not an actual dependency... darn.

Okay. Add this to the project page in the OAuth section:

Dependency requirements for Oauth:

Twitter Version          OAuth Version

5.x-1.x                        (None)
< 6.x-3.0-beta5          6.x-2.02 (Only!)
>= 6.x-3.0-beta5       6.x-3.x
7.x-3.x                       7.x-3.0

Edit and fix my probably wrong version list as needed, but I would like it on the actual project page, that way there is no doubts about what version to use.

Best,
Sam

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Title: What version of oauth_common should be used? » Add dependency version info to Twitter 7.x
Version: 6.x-3.0 » 6.x-3.x-dev
Category: support » task
Status: Fixed » Needs work

I will test it to be sure, but I'm pretty sure that syntax is only for 7.x and not 6.x. I do think we should add that to the 7.x module. Hijacking issue :)

* Writing .info files (Drupal 7.x)
* Writing .info files (Drupal 6.x)

Michael-IDA’s picture

Michael-IDA commented
Version: 6.x-3.x-dev » 7.x-3.x-dev

Hijack away, and up'ed the version to 7.x .dev

Hmm, you're right, and I thought for sure I'd seen 6.x modules do that in the past.

Edit:
Too bad OAuth isn't a hard dependecy in 6.x-3.x, I'd almost say add "dependencies[] = oauth" to the .info even if it was wrong, just to avoid this problem...

juampynr’s picture

juampynr commented

For 7.x-4.x and 6.x-4.x OAuth is a dependency. I am considering renaming the OAuth module files back to oauth in order to avoid these sort of confusions. I first need to find out why they were changed to oauth_common.

dddave’s picture

dddave commented
Version: 7.x-3.x-dev » 7.x-6.x-dev

still relevant?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@juampy: Any update on renaming the OAuth module files?

FYI I added a patch in #1967798: Problem with the OAuth / oauth_common dependency that adds some code to hook_requirements to explain which module to download.

ed523’s picture

ed523 commented

need this too, subscribing

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Active
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Component: Twitter Actions » Code
Status: Active » Needs review
StatusFileSize
new twitter-n1829712-10.patch906 bytes

Of course we could just use the new dependency structure in v7.40 :)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 7.x-5.x-dev
StatusFileSize
new twitter-n1829712-11.patch994 bytes

Ported to 7.x-5.x.

Status: Needs review » Needs work

The last submitted patch, 11: twitter-n1829712-11.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Fixed

Committed.

  • DamienMcKenna committed 63d3862 on 7.x-6.x 
    Issue #1829712 by DamienMcKenna: Expanded dependency information for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.