Problem/Motivation

This is a follow-up issue from #1831530: Entity translation UI in core (part 2)
The question was to investigate if one should change dropbutton labels on translations tab to "add translation" / "edt translation".

Proposed resolution

The dropbutton should not be changed because you are on the translation page and if it said "add translation" it would 1) be too verbose and 2) deviate from comment pattern in core.

Remaining tasks

Patch was already created in #6.
Screenshot was created in #12.
UI review is done by Gabor in #13 and by Bojhan in #14.
Won't fix.
Nothing more to do.
Here is the Follow-up, based on comment #11 : #1832778: Include translation operation in overviews for translatable entities

User interface changes

See above.

API changes

No API changes.

Original report

I am creating this issue coming from the meta issue #1188388: Entity translation UI in core.

Comments

luksak’s picture

Status: Active » Needs review
StatusFileSize
new1.86 KB

Here is the patch.

luksak’s picture

Assigned: Unassigned » luksak
gábor hojtsy’s picture

Component: entity system » translation_entity.module
Issue tags: -entity translation +D8MI, +language-content
plach’s picture

Issue tags: +Usability
draganeror’s picture

Status: Needs review » Needs work

'delete' also should be changed to 'delete translation'.

draganeror’s picture

Title: Change dropbutton labels on translations tab to "add translation" / "edt translation"? » Change dropbutton labels on translations tab to "add translation" / "edit translation" / "delete translation"?
Status: Needs work » Needs review
StatusFileSize
new1.95 KB

Changed 'delete' label to 'delete translation'.

Status: Needs review » Needs work

The last submitted patch, 1831604-et-dropbutton-labels-6.patch, failed testing.

ytsurk’s picture

a link to the translations tab could already be displayed on the main content overview drop down.

this would probably introduce a hook in entity_translation, did not find it till now - too much time spent already ..
(tried translation_entity_node_operations > this is for bulk ops, and translation_entity_menu_local_tasks_alter > this is for the blue links on top .. )

gábor hojtsy’s picture

Status: Needs work » Needs review
Bojhan’s picture

Needs screenshot

ytsurk’s picture

StatusFileSize
new250.96 KB

i would like the link to the translations here too :D

draganeror’s picture

StatusFileSize
new83.02 KB

@Bojhan here it is.

Change dropbutton labels on translations tab

gábor hojtsy’s picture

Yeah, hm, as with the phone call where we discussed this I'm not sure that this is an improvement per say. You *are* on the translation page. I mean on the views screen or the node admin page, the links do not say "edit view" or "edit post", they just say edit, because the context makes the action evident. This looks very un-Drupal AFAIS. Essentially too verbose. However, this is just IMHO, so if people feel this is an improvement nonetheless, I have no intention to stop it :D

Bojhan’s picture

I am pretty sure its not really an improvement, so I would just won't fix this.

You are in the language flow, the buttons don't necessarily need to signal that. And doing so actually makes it a lot harder to scan, than without.

Anonymous’s picture

Why is it difficult to understand that "edit", "add" or "delete" on this page row means to edit, add or delete the translation? Why do we need to add to the word translation to double up on the wording? We are already on a page that is related to "translation" we do not need to see it on every row on the page to make it more clear because it isn't any more clear. More text isn't always good, for one thing it takes up screen real estate.

gábor hojtsy’s picture

Status: Needs review » Closed (won't fix)

Right, ok, we agree then. Thanks for the work guys, don't give up just yet :)

ytsurk’s picture

Status: Closed (won't fix) » Needs review

actually, i don't see the textual change as an improvment, but #11 would be - at least for me .., saving a click.

gábor hojtsy’s picture

Status: Needs review » Closed (won't fix)

@ytsurk: Yes, I think an issue for that would be great to have. :) Not to overload this one. Same applies for taxonomy terms, etc. I'd have loved to have that quick access as well as I tried it out.... Can you open a new issue?

ancamp’s picture

I updated the issue summary

gábor hojtsy’s picture

If/when someone creates an issue for #11, please link it in here :)

gábor hojtsy’s picture

Well, created this one: #1832778: Include translation operation in overviews for translatable entities. Anybody want to look into working on it? :) I think the hard part about it will be that you need to check per entity on each row. The set of operations will possibly be different for different nodes based on whether they are translatable or not (have a base language, node type configured to be translatable, etc). Same for taxonomy terms, etc. I think the visibility/access rules for the menu tab would need to be applied essentially.

(Posting same on that issue).

gábor hojtsy’s picture

Issue summary: View changes

Issue summary updated.

ancamp’s picture

Issue summary: View changes

Updated issue summary with the link to the follow-up issue