It's a long story, but due to fatal errors in certain environments triggered by Migrate's automated registration of migration and handler classes, as of Migrate 2.5 it will be possible to disable auto-registration, and any module implementing migration or handler classes should explicitly register them via hook_migrate_api() to continue working when auto-registration is disabled. Adding this registration will have no effect with Migrate 2.4 or earlier. This patch registers the Date field handler.

CommentFileSizeAuthor
#2 migrate_class_registration-1832544-2.patch1.41 KBmikeryan
migrate_class_registration.patch364 bytesmikeryan

Comments

Status: Needs review » Needs work

The last submitted patch, migrate_class_registration.patch, failed testing.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs work » Needs review
StatusFileSize
new migrate_class_registration-1832544-2.patch1.41 KB

Right, the example module also needs to register its migration class...

jantoine’s picture

jantoine commented
Status: Needs review » Reviewed & tested by the community

Code is clean and causes the Date Migrate module to function correctly with the Migrate module v7.x-2.5.

jamsilver’s picture

jamsilver commented

I can also confirm that this works when auto-registration is turned off.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Priority: Normal » Major

Upgrading priority - migrating into date fields is completely broken with Migrate 2.5 or greater without this patch.

mxt’s picture

mxt
Primary language Italian
Location Milan
commented

Yes I can confirm that patch provided in #2 works well also for me.

Can this be committed please?

fmitchell’s picture

fmitchell commented

I can also confirm that this fixes Date Migrate with Migrate 7.x-2.5.

wusel’s picture

wusel commented
Title: Class registration for Migrate 2.5 or later » Class registration for Migrate 2.5 or later / please commit patch
Category: task » bug

I can also confirm that this works with 'migrate 7.x-2.5+107-dev (2013-Apr-25)', but NOT works without it.

Please take a look at #1981162-1: No handler for date_migrate.

Thank you for updating in the very next days.

Wusel

PatchRanger’s picture

PatchRanger commented
Status: Reviewed & tested by the community » Closed (duplicate)

Thanks for the patch, it works for migation issue, which is topic-starter, but it is not enough to fix the issue from #1835214: Automated tests failing - Exception thrown in Date2 migration.
Closing as a duplicate of that issue, because it has an improved version of this patch.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Closed (duplicate) » Reviewed & tested by the community

We have a long-standing patch here in RTBC status, closing it in favor of a newer patch is unhelpful in terms of getting it in.

PatchRanger’s picture

PatchRanger commented

If you prefer RTBC - I wouldn't mind.
Just keep in mind, that this patch is not enough, it doesn't really fix issue from #1835214: Automated tests failing - Exception thrown in Date2 migration, though it looks good for this concrete issue. In fact both patches do have common basis, I based on this one while creating my patch, thank you.

bleen’s picture

bleen commented

RTBC++

kostajh’s picture

kostajh commented

This patch works for me.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented

This patch has been incorporated into the consolidated patch at #2034231: [META] Integrated patch for migration changes.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Title: Class registration for Migrate 2.5 or later / please commit patch » Class registration for Migrate 2.5 or later

Let's not nag in the title.

cafuego’s picture

cafuego commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.