Adds the block's title to the block's set of HTML classes (specifically to the block's $classes array variable). Useful when theming to quickly identify and target individual blocks.

This is different from Block Class. Block Class requires users to manually add a class on the block's configuration page. This module is totally automated, and requires no user configuration.

Project page: http://drupal.org/sandbox/deckerdev/1810682

Git repo: git clone --recursive --branch 7.x-1.x deckerdev@git.drupal.org:sandbox/deckerdev/1810682.git block_title_class

This is a D7 module.

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Welcome,

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

adamelleston’s picture

adamelleston commented
Status: Needs review » Needs work

Using the following as a structure for my review http://drupal.org/node/894256 and http://groups.drupal.org/node/184389

README.txt
Its a simple enough module so the readme.txt is appropriate

Project page
Need some information on the project page as to what it does and doesn't do, any other modules that may provide functionality that this doesn't offer. Maybe link to the Block class module.

Master Branch
Branches match naming conventions.

Major coding standards / best practice issues
Ran through the automated system at ventral.org and no issues found.

Looking through the code manually it also looks fine, however I think the small amount of code here is very hard to use as a review.

License
No License file, check.

Access administration vs. Administer site configuration
Not relavant as this module just exists in an on of off state depending if the module is enabled/disabled.

files[] without classes or interfaces
None, check.

Licensing issues
No License file, check.

Multiple Applications
Nope

Idle Application
Nope, still active.

Code too short
This project does not meet the minimum 120 line requirement. I am not sure how you could extend the module to offer more functionality to meet this requirement without bloating it with non required features or creating an overlap between what this module and block class does. This may stop the project being able to pass this approval.

Duplicate module
Can't find a module that does what you have done in this project.

rrrob’s picture

rrrob commented
Status: Needs work » Needs review

@adamelleston: thanks for reviewing.

I've updated the project page with some additional information as you've suggested. Please let me know if this explains the module sufficiently.

As for code length, I know it's too small a sample for me to be given module publishing permissions, but I'd like to get this module published anyways. I'm not overly concerned that I get the permission in the process. According to section 2.3 at http://drupal.org/node/1587704, this module could get promoted to a full project manually. That'd be fine with me.

adamelleston’s picture

adamelleston commented

@rrrob the updated project page looks a lot better!

I think all left to do is get a review bonus as klausi said previously then update this with the 3 reviews and tag with with PAReview: review bonus

wolvern’s picture

wolvern commented

Hi, rrrob

yours is a neat little module and performs a very useful function. Also, it could probably compete for a title of the smallest Drupal module :)

But I think it could really easily be incorporated into aforementioned Block Class module - it could sit there as a single checkbox and be a perfect addition. What do you think?

arun ak’s picture

arun ak commented
Status: Needs review » Needs work

Hi saulelis,

I agreed with you. Its easy to integrate this functionality with Block Class module.

rrrob’s picture

rrrob commented

I'll check with the Block Class developers and find out their interest in adding additional functionality.

Update: Here's the link to the issue I posted: http://drupal.org/node/1838888

rrrob’s picture

rrrob commented

Still no word from the Block Class developers.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

Updated repo.