In a few months ago, i used an own version(http://drupal.org/node/1498892).
Now, It has multi-language version, I re development it dependencies by wysiwyg module.

UEditor is Baidu web front-end R & D department developed
WYSIWYG rich text web editor, with a lightweight, customizable,
and focus on user experience and other characteristics,
the open source BSD license, allowing free use and modify the code.

The 1.2.3.0 version is dependencies by wysiwyg module.

Demo: http://ueditor.baidu.com/website/onlinedemo.html
The demo is chinese, You can use the en version on your download.

Installation
-------------
1. Download the ueditor 1.2.3.0 in
http://ueditor.baidu.com/build/build_down.php?t=1_2_3_0-utf8-php.
2. Unzip it into sites/all/libraries,
so that there's like sites/all/libraries/ueditor/editor_all_min.js.
3. Enabled ueditor module.

Configuration
-----------------
This file is chinese language by default.
You can custom configuration in
http://ueditor.baidu.com/website/ipanel/panel.html,

Because the editor official website provides
very complete configuration tool.
So, There will be no more configuration options appear
in the WYSIWYG module configuration page.
Just put in the official website of the generated files
copy into the sites/all/libraries, and write the file name
in the WYSIWYG module configuration page textfield(Config js filename).

If you want, you can use the website to provide advanced configuration page.
It is in the second tab.

Unfortunately, the official website of the Chinese,
You can use the google translation, the operation so easy.

Project sandbox: http://drupal.org/sandbox/willietse/1498876
Clone repository: git clone http://git.drupal.org/sandbox/willietse/1498876.git
Drupal version: 7.x

Comments

mschudders’s picture

mschudders commented
Status: Needs review » Needs work

Hi there,

Could you please create an branch (like 7.x-1.x) ? (This is a must :-) )

Parreview seems ok: http://ventral.org/pareview/httpgitdrupalorgsandboxwillietse1498876git

Kind regards

willietse’s picture

willietse commented

Thank you.
I created an branch 7.x-1.x.

willietse’s picture

willietse commented
Status: Needs work » Needs review

Forget to change states. :-)

adamelleston’s picture

adamelleston commented
Status: Needs review » Needs work

Using the following as a structure for my review http://drupal.org/node/894256 and http://groups.drupal.org/node/184389

README.txt
Would be good to get some more details in here about downloading and configuring the editor for other languages.

Project page
The project page seems a little light in terms of content. Take a look at some related modules to see how you can improve the page.

http://drupal.org/project/wysiwyg
http://drupal.org/project/bueditor

Master Branch
You are working on the master branch, you should follow the steps here as branches match naming conventions.

Major coding standards / best practice issues
Ran through the automated system at ventral.org and no issues found.

The code looks ok after a manual review. Indents, comments all look ok.

License
No License file, check.

Access administration vs. Administer site configuration
All handled via text formats and WYSIWYG formats so N/A

files[] without classes or interfaces
None, check.

Licensing issues
No License file, check.

Multiple Applications
N/A

Idle Application
Still active

Code too short
This project just about covers the minimum 120 line requirement. It could be increased to provide more options like the CKEditor so that users customize what buttons/controls are shown on each text format.

Duplicate module
Can't find an existing module

I couldn't fully test the working of the editor as the alt/title text when you hover over is in Chinese.

Once issue I have noticed is when you try and disable the text editor using the "Disable rich-text" link below the text area it doesn't disable the editor. Then when you try and click again to re-enable it adds a another editor below so you have multiple editors for the text area.

Also I am not sure if its this module but the site I installed it on does seem to spend forever loading when accessing a page trying to use the editor. Seems to be related to the core overlay module as when I remove the #overlay= from the url it loads the page fine. So you may want to check that out first

willietse’s picture

willietse commented
Status: Needs work » Needs review

README.txt
补充了README.txt。

Project page
Code too short
Because ueditor dependencies by wysiwyg module and the official website provides better complete configuration page.

only need to use the WYSIWYG module API, can reach the final desired effect, include like the CKEditor so that users customize what buttons/controls are shown on each text format, everything in the configuration js file.

WYSIWYG is a very good module and Ueditor is a good editor, has a very good features and user experience, especially in China. Standing on the shoulders of giants, so don't need too much code, some code is in the ueditor.inc file(According to WYSIWYG API).
I just need to invoke an editor, About this, do you have any good suggestions to me, thanks.

Master Branch
I created an branch 7.x-1.x.

Access administration vs. Administer site configuration
It is dependencies by wysiwyg.

files[] without classes or interfaces
Have no.

License
Have been added. :-)

Add 3 configuration option in the WYSIWYG,
1, Default language for English.
2, zindex, Repair and the module of overlay conflict.
3, Editor initial content, after editor loading in the textarea,(if the default is chinese, so...)

using the "Disable rich-text" is fine.
All configuration in the configuration js file,
so some of the WYSIWYG module configuration is invalid.
I refer to the WYSIWYG module, some editor configuration is invalid.

At the #overlay= page, if use chrome, have not loaded, ueditor and overlay conflict,
I checked the other browser, not in the #overlay= page, all browser are worked.
At the #overlay= page, all browser are worked except chrome.
I cannot modify the ueditor core files, I have to submit a question to the official site, on this question, can I aside?waiting for the official patch.

willietse’s picture

willietse commented

I deleted LICENSE.txt.

http://ventral.org say "Remove LICENSE.txt, it will be added by drupal.org packaging automatically."

jsacksick’s picture

jsacksick commented

From what I can see the code seems ok I didn't have time to install the module but it seems good except that you should probably fulfill the project page, the README.txt is actually more complete than the product page.
You could copy paste the configuration instructions from the README.txt to the project page for instance.

jsacksick’s picture

jsacksick commented
Issue summary: View changes

project sandbox url.

willietse’s picture

willietse commented
Issue summary: View changes

update descriptions.

willietse’s picture

willietse commented

That's a good idea. Thanks.

herom’s picture

herom commented
Status: Needs review » Needs work

there seems to be some issues in your pareview (which includes having a master branch):
http://ventral.org/pareview/httpgitdrupalorgsandboxwillietse1498876git

ueditor.inc

  • you shouldn't put static links directly inside your t() functions, but in the parameters instead.
    For more information on using t(), check here:
    http://drupal.org/node/322774
  • line 84-86: meaning of the text inside the t() function is not clear at all.


you could also keep a list of incompatibile features of "UEditor" and "Wysiwyg" (or even try to fix them!). For example:

  • submitting the text while in the "html" mode of ueditor, messes up the text badly.
  • the fullscreen button in ueditor doesn't work right, as it can't fill the whole screen (and it broke even further once i opened firebug!).

i haven't test all the buttons and features, so other issues might exist with the editor.

one really minor issue is using both "UEditor" and "Ueditor" as the name of the editor, throughout your code. It is better to keep one of these casings, and replace the other.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

update descriptions.