Little small problem with views and overlay.

See #1806308-9: Review Views JavaScript + generic modals for accessibility.

CommentFileSizeAuthor
#3 core-views-overlay_modal-1833678-3.patch837 bytesnod_
core-views-overlay_modal.patch735 bytesnod_

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented

Make sure to clear browser cache. Overlay iframe can have trouble with that.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +VDC

tag

nod_’s picture

nod_
Primary language French
Location Lille
commented
Title: Views modal is broken when using overlay » Ajax is messing with overlay
Component: views_ui.module » javascript
StatusFileSize
new core-views-overlay_modal-1833678-3.patch837 bytes

A clean-up patch removed some return false; #1749782: Use event.preventDefault(); and event.stopPropagation(); instead of return false; that made the overlay behave strangely with views and modal.

This should fix it globally.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Priority: Normal » Major

That's a important one, makes the abstracted modal patch do workarounds and as said before, is messing with views UI.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

That issue has come back to bite us quite a few times. Oh well, glad it wasn't a Views bug :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Grumble grumble. :)

dawehner’s picture

dawehner
Primary language German
commented

Should this maybe backported to d7?

Automatically closed -- issue fixed for 2 weeks with no activity.