Needs review
Project:
Fivestar
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Nov 2012 at 11:32 UTC
Updated:
19 Sep 2018 at 15:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
adelka commented@bingorabbit - I wanted to test it, but is the pach ok? I can see only two lines of code but there is no information about file, line etd.
Comment #2
PMZ commentedSomething new about this issue and the proposed solution? Is the proposed patch safe?
Thanks for info!
(I am using the: 7.x-2.0-alpha2 version)
Comment #3
Mikel_And_Mendizabal commentedAny news on this?
I am trying this patch and the ones for D6, but nothing works....:(
Any ideas?
Comment #4
ibrahim.mohamed commentedSorry for being late..Resubmitting the patch!
Comment #6
ibrahim.mohamed commented#4: fivestar.patch queued for re-testing.
Comment #8
Charlouze commentedAttached is your patch corrected to be appliable by git.
Comment #9
Charlouze commentedComment #11
Darc_Nite commentedI looked over this patch and implemented in my site manually and i found three bugs in it (which i fixed as i went)
should be
the same in
fivestar_form_submitandfivestar_ajax_submitComment #12
oleg.medvedev commentedComment #13
oleg.medvedev commentedComment #14
whiteph commentedHas anyone with a multilingual site tested the fix in #12? If someone can confirm it is working, I'll commit it to the 7.x-2.x dev branch.
Comment #15
mjanouch commentedWorks for me.
Comment #16
le72On module version 7.x-2.1 getting notice:
indeed
should be replaced with
$node->tnid is always set. It is 0 if no translation.
Comment #17
danitochilin commentednot work in version 7.x-2.1 fivestar
when change language get this error:
Notice: Undefined index: average em fivestar_expand() (linha 648 de /home/.../sites/all/modules/fivestar/fivestar.module).
Notice: Undefined index: count em fivestar_expand() (linha 649 de /home/.../sites/all/modules/fivestar/fivestar.module).
Notice: Undefined offset: 0 em fivestar_field_formatter_view() (linha 491 de /home/.../sites/all/modules/fivestar/includes/fivestar.field.inc).
Comment #18
adelka commentedWould be great to have a version for version 7.x-2.1
Comment #26
adriancidI created this patch for voting in each translation of the node when you use i18n.
Comment #27
adriancidComment #29
silver157 commentedAny updates for this problem?
Comment #30
adriancid@silver157 I don't know why my pacth failed in the test. If you want test it in your site, it work for me
Comment #31
silver157 commentedand i tested it and it works with me :)
Thanks a lot Adrian :)
Comment #32
adriancidI created this patch for voting in each translation of the node when you use i18n. I make the patch again because it seems that before there was a error with the line numbers. So this is the same code of the patch #26
Comment #33
adriancid