Elementary is a super simple Drupal 7 theme ideal for blogs. The main goal of the theme is to be as simple as possible with a focus on written content above all else.

Key elements:

  • Single column
  • Just two regions: content & footer
  • Fixed header for screen sizes above 400px
  • Responsive
  • Setting between serif/sans-serif font
  • Option to remove all other CSS provided by core/contrib for logged out users

Project page:
http://drupal.org/sandbox/tedavis/1833576
Repo:
git clone http://git.drupal.org/sandbox/tedavis/1833576.git elementary

Desktop screenshot:
Desktop screenshot

Mobile screenshot:
Mobile screenshot

Reviews of other projects:

http://drupal.org/node/1827294#comment-6712528
http://drupal.org/node/1829098#comment-6713372
http://drupal.org/node/1834738#comment-6721744

Comments

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Status: Needs review » Needs work

Please fix the coding style issues detected by automated tool : http://ventral.org/pareview/httpgitdrupalorgsandboxtedavis1833576git

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review

Coding style issues should now be resolved.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes

Changed image size

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes

Added in first review

anydigital’s picture

anydigital CreditAttribution: anydigital commented

Hi tedavis,

1) template.php: I think it's not good to call drupal_add_css() in the global context. Place it inside elementary_preprocess_page()
2) block.tpl.php: in templates you should to add semicolon (;) after all ending clauses and also leave one space after them
3) it's very minor but you should use <code> tag for your git instructions on project page

anydigital’s picture

anydigital CreditAttribution: anydigital commented
Status: Needs review » Needs work
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review

@tonystar thanks for the review,

1. Changed.
2. Added the additional semicolon but it actually looks like the core block.tpl.php is missing this too, a bug with core perhaps?
3. Not sure what you mean with this, my sandbox page only has the default git instructions provided by d.o & I did use the code tag for this issue.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes

Another review added

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue tags: +PAreview: review bonus

Added in project reviews

stixes’s picture

stixes CreditAttribution: stixes commented

Automated:
Automated review with PAReview comes up clean.

Manual:
Looks pretty good. I would like an easy option for subtheming. Being minimalist, it seems obvious to include a starterkit subthemes (also, it a rather simple thing to do), however it's not really a requirement for review.

I would need to see the timestamps locallized. Either by adding a custom format or using the standards.

Documentation:
Proper formatted, and decent explainations. I do think the term "super simple theme" used on the project page should be replaced by "minimalistic" as used in the README, since "simple" can be alot of things, not just layout related.

stred’s picture

stred CreditAttribution: stred commented
Pareview
Automated review do not output anything (errors or even warnings).
Repository
You should remove the screenshot.png from images folder.
Code
The permission used on line 40 in template.php does not exist. You could use 'access administration pages' instead
hook_preprocess_textarea() used on line 40 in template.php does not exist. The resize feature is not removed (theme_textarea exists but i don't know why the setting is overridden... ?)
When serif font option is chosen, there is a problem with the padding of the ul.tabs li (works ok for me on firefox 16.0.2 with padding: 4px 10px; )
Don't know why you force date to be displayed as 'd M Y'. It won't suit everyone and you lose some flexibility

these are only remarks, nothing critical here...

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

@stred Thanks for the comments, much appreciated.

I've now removed the additional screenshot file.

hook_preprocess_textarea was an incorrect comment on my part - should have been theme_textarea. All this does is remove the grippie from the text area, it should still be resizable by default in modern browsers so the grippie isn't really needed anymore.

Just updated the padding for the tabs which should now fall into place & the permission should be correct now.

In terms of the date, I do see what you mean in terms of flexibility but when I had it set to the default it just didn't seem to look right, there was too much going on. I'll definitely have a think though, if more people would like the flexibility I'll probably put it back.

Let me know if you find anything else!

stred’s picture

stred CreditAttribution: stred commented
Status: Needs review » Reviewed & tested by the community

you could use the format_date with 'short' instead of 'custom' so people can easily modify the display as they like... but anyway I change the status to reviewed.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, tedavis!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Awesome, thank you!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Added 3rd project review