Webform Remote Post is a module that works along the Webform module. It eases the integration between Webforms and other web applications by extending the out-of-the-box functionality if the Webform module.

By default, the Webform module only knows how to email successful form submissions individually to one or more email addresses. In an enterprise environment (a company website that has forms that generate leads for example), having a Drupal site send hundreds of emails per day to a person is not scalable. This module allows web form submissions to be sent automatically to any number of 3rd party applications - no more emails, just a direct passing of the data between the Drupal site and your other systems.

Previously, if you needed to do further processing of webform submits, you would need to create a custom module and write some code to do that you need. With this module, you don't need to write code anymore. Just point a webform to one or more systems for those systems to handle the data.

Per the spirit of collaboration over competition, before starting this module, I got in touch with quicksketch to see if the functionality could be added to the Webform module. He seemed to like the idea, but for a companion module, rather than changing Webform itself: http://drupal.org/node/1728328#comment-6380976

Note: This is my first contrib module :-]

Regards,
Enrique.

Comments

ahlofan’s picture

ahlofan commented
Status: Needs review » Needs work

Hi,

Your module seems straight forward, however, some little problems found here...
Please fix as much errors as possible found here: http://ventral.org/pareview/httpgitdrupalorgsandboxenriquedelgado1786762git

smiletrl’s picture

smiletrl commented

Hi, this module looks great. Although, some little concerns are followed:

In webform_remote_post.install file, section of hook_uninstall(), if this function does nothing, I think we could safely remove this part code.
For function webform_remote_post_update_7001(), this hook http://api.drupal.org/api/drupal/modules%21system%21system.api.php/funct... is used to update the site. When enabled firstly, this function doesn't run, and in database, we can't see field 'enabled' in table webform_remote_post_targets. And, I run update.php in site, but this function doesn't work either .Not sure does this field get used later, but I guess we could do something better with this code. Why don't we directly add the field in 'hook_schema()' :)

In webform_remote_post.targets.inc, drupal_render($form['targets'][$tid]['status']), I'm not sure what's included in the form element that you want to use drupal_render, but I guess if this form element is not that complicated(another structured array tree?), we could directly use the check_plain($form['targets'][$tid]['status'])?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

enrique.delgado’s picture

enrique.delgado commented

Ok, thanks. I'll have something to review soon. Sorry for the delay.

enrique.delgado’s picture

enrique.delgado commented
Status: Closed (won't fix) » Needs review

First off, thanks so much for your reviews so far and an apology for taking so long to address the issues found. I got a little demotivated to see so many issues :-/ But I'm back!

  • @ahlofan, thanks for the tip. I've corrected all the errors and warnings found by http://ventral.org/pareview/httpgitdrupalorgsandboxenriquedelgado1786762git, there were quite a few!
  • @smiletrl, I've removed webform_remote_post_update_7001() in and added the enabled column into the main schema as suggested. Great idea. I was not able to replace drupal_render() with check_plain() :-/ bootstrap.inc complains when I do so: Warning: htmlspecialchars() expects parameter 1 to be string, array given in check_plain()

Thanks!

blc’s picture

blc commented
Status: Needs review » Needs work

* The git repo in your summary needs to be updated for anonymous copy/paste

git clone --recursive --branch 7.x-1.x http://git.drupal.org/sandbox/enrique.delgado/1786762.git webform_remote_post

* No master branch in the git repo. All is well there.

* 12 functions, and 300+ lines of code. Module size is ok.

* PHP_CodeSniffer did not find any problems.

* Code is well commented.

* Line 30 of webform_remote_post.module, "will" is typo'd.

* No obvious security issues found.

Just a couple of minor things to fix. Other than that, looks good to me.

blc’s picture

blc commented
Issue summary: View changes

Fixed branch name.

enrique.delgado’s picture

enrique.delgado commented
Status: Needs work » Needs review

Hi blc,

  • I've corrected the git repo in the summary of this issue.
  • The typo in line 30 of webform_remote_post.module has been corrected.

Thanks for reviewing my module!

iwhitcomb’s picture

iwhitcomb commented
Status: Needs review » Reviewed & tested by the community

This all looks good to me, awesome module idea

enrique.delgado’s picture

enrique.delgado commented

Thanks iwhitcomb! Okay, so what happens now? :-]

Also, I haven't been writing more features to my module because I do not want to modify what has been tested and reviewed by the community. Is it safe to do so in a branch? If so, what's the convention for that branch name (given that we do not use "master")? Would it be 7.x-dev?

Thanks everyone that has helped so far.

iwhitcomb’s picture

iwhitcomb commented

Honestly, I would wait on adding anything else to the module for now.

The review bonus will usually get you a faster response. It's kind of a pain, but worth it if you're anxious to get your application approved.

jthorson’s picture

jthorson commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, enrique.delgado!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

enrique.delgado’s picture

enrique.delgado commented

W00t! Thank you jthorson and everyone that helped review this first module of mine! I'll take a look at the resources you pointed me to and flip the switch for the Drupal community to find my module.

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Changed git repo instructions for anonymous copy/paste