Closed (fixed)
Project:
Email Registration
Version:
5.x-1.3
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
16 Oct 2007 at 08:47 UTC
Updated:
11 Feb 2009 at 23:11 UTC
Jump to comment: Most recent file
When profile.module is enabled, it won't hide username input field from registration form.
That's because profile module will change the array of form to $form[category_name]['name'] instead of just $form['name'].
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | email_registration_nodeprofile_fix.patch | 1.04 KB | faction |
| #1 | email_registration_profile_fix_1.patch | 863 bytes | sign |
| email_registration_profile_fix.patch | 1.43 KB | sign |
Comments
Comment #1
sign commentedactually it applies only in user_register form.
Comment #2
Christopher Herberte commentedapplied this patch http://drupal.org/node/183820
This seems like a sane way to fix the bug. module_exists() checks if the profile module is installed (of course, it's core) AND enabled which is that bit I was not sure on.
Thanks for the patch, sorry it took so long it'll be available in 5.x dev snapshot and next stable release.
Comment #3
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #4
scottrigby#1 works for me. I know the issue is closed, but just another bit of positive feedback ;) thanks!
Comment #5
Christopher Herberte commentedThanks for the feedback Scott.
I am opening this issue back up because the same thing is happening with nodeprofile.module I just discovered.
I will apply the patch and commit it soon.
Comment #6
dorien commentedI have the profile module and the latest version (I checked it has the patch). But the username field keeps showing!
Comment #7
dorien commentedLet me clarify a bit:
It works fine on the login page. But the registration page keeps showing username whenever profile is enabled.
I am working on Drupal 5.7.
Comment #8
jayson commentedHi, I also have this problem with nodeprofile.module, has anyone fixed this yet? Thanks!
Comment #9
faction commentedRather than checking for a specific module, it seems to be much safer to just check for the existence of the $form['name'] and $form['account'] variables. Generalizing the code like this will ensure email_registration will work for profile, node profile, or any other module that alters the sign up form (including custom modules). This will also solve the problem of someone having node profile installed, but not configured to alter the sign up form.
BTW - This my first code patch submission... so please be kind if I beefed it up. Thx.
Comment #10
Christopher Herberte commentedComment #11
Christopher Herberte commentedfaction, thanks. Your patch did not work but that's ok. 1 liner.
I'm committing this to HEAD please confirm that it's working.
Comment #12
sbandyopadhyay commentedLooks like this issue has been resolved a while ago.
Comment #13
Christopher Herberte commented